You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "fallintoplace (via GitHub)" <gi...@apache.org> on 2026/08/29 09:48:06 UTC
[PR] perf(table): skip manifests with no live entries [iceberg-go]
fallintoplace opened a new pull request, #1964:
URL: https://github.com/apache/iceberg-go/pull/1964
## Summary
- Skip data and delete manifests when both `added_files_count` and `existing_files_count` are known to be zero.
- Keep manifests with unknown counts for safety.
- This avoids opening manifests that only contain deleted entries.
- Added scanner regression coverage and a planning benchmark.
## Benchmark
Command: `go test -run '^$' -bench '^BenchmarkPlanFilesSkipsKnownEmptyManifests$' -benchtime=2s ./table`
Apple M1 Pro, 256 manifests, 64 entries per manifest.
| Case | Before | After |
| --- | ---: | ---: |
| All empty | 65.0 ms/op, 256 manifest opens/op | 0.31 ms/op, 0 manifest opens/op |
| 10% live | 65.6 ms/op, 256 manifest opens/op | 10.7 ms/op, 26 manifest opens/op |
Allocations also dropped from 81.0 MB to 0.32 MB per operation for the all-empty case, and from 81.6 MB to 9.1 MB for the mixed case.
## Checks
- `go test ./table -count=1`
- `go test -race ./table -count=1`
- `golangci-lint run --timeout=10m`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] perf(table): skip manifests with no live entries [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #1964:
URL: https://github.com/apache/iceberg-go/pull/1964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org