You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2025/05/03 18:41:00 UTC
[PR] Status: Split read/write and add deletion vectors [iceberg]
Fokko opened a new pull request, #12958:
URL: https://github.com/apache/iceberg/pull/12958
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Status: Split read/write and add deletion vectors [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12958:
URL: https://github.com/apache/iceberg/pull/12958#issuecomment-2968556998
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Status: Split read/write and add deletion vectors [iceberg]
Posted by "singhpk234 (via GitHub)" <gi...@apache.org>.
singhpk234 commented on code in PR #12958:
URL: https://github.com/apache/iceberg/pull/12958#discussion_r2072449201
##########
site/docs/status.md:
##########
@@ -163,9 +163,18 @@ This section lists the libraries that implement the Apache Iceberg specification
| Operation | Java | PyIceberg | Rust | Go |
|------------------------|------|-----------|------|----|
| Append data | Y | Y | Y | N |
+| Read position deletes | Y | Y | N | N |
| Write position deletes | Y | N | N | N |
+| Read equality deletes | Y | N | N | N |
| Write equality deletes | Y | N | N | N |
+### Table Spec V3
+
+| Operation | Java | PyIceberg | Rust | Go |
+|------------------------|------|-----------|------|----|
+| Read deletion vectors | Y | Y | N | N |
+| Write deletion vectors | Y | N | N | N |
Review Comment:
[suggestion] should we also add Read Pos / Read eq / Write eq matix, also in spec v3 considering they are still supported in v3 as well ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Status: Split read/write and add deletion vectors [iceberg]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #12958:
URL: https://github.com/apache/iceberg/pull/12958#discussion_r2075502494
##########
site/docs/status.md:
##########
@@ -163,9 +163,18 @@ This section lists the libraries that implement the Apache Iceberg specification
| Operation | Java | PyIceberg | Rust | Go |
|------------------------|------|-----------|------|----|
| Append data | Y | Y | Y | N |
+| Read position deletes | Y | Y | N | N |
| Write position deletes | Y | N | N | N |
+| Read equality deletes | Y | N | N | N |
| Write equality deletes | Y | N | N | N |
+### Table Spec V3
+
+| Operation | Java | PyIceberg | Rust | Go |
+|------------------------|------|-----------|------|----|
+| Read deletion vectors | Y | Y | N | N |
+| Write deletion vectors | Y | N | N | N |
Review Comment:
I would rather leave out the duplication. See also https://github.com/apache/iceberg/pull/12959.
Duplicating everything makes it more prone to discrepancies. For example, I don't think we should not add `Append data` to V2. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Status: Split read/write and add deletion vectors [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #12958: Status: Split read/write and add deletion vectors
URL: https://github.com/apache/iceberg/pull/12958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Status: Split read/write and add deletion vectors [iceberg]
Posted by "singhpk234 (via GitHub)" <gi...@apache.org>.
singhpk234 commented on code in PR #12958:
URL: https://github.com/apache/iceberg/pull/12958#discussion_r2076552320
##########
site/docs/status.md:
##########
@@ -163,9 +163,18 @@ This section lists the libraries that implement the Apache Iceberg specification
| Operation | Java | PyIceberg | Rust | Go |
|------------------------|------|-----------|------|----|
| Append data | Y | Y | Y | N |
+| Read position deletes | Y | Y | N | N |
| Write position deletes | Y | N | N | N |
+| Read equality deletes | Y | N | N | N |
| Write equality deletes | Y | N | N | N |
+### Table Spec V3
+
+| Operation | Java | PyIceberg | Rust | Go |
+|------------------------|------|-----------|------|----|
+| Read deletion vectors | Y | Y | N | N |
+| Write deletion vectors | Y | N | N | N |
Review Comment:
I agree, the only consideration is how we do we convey a case like :
pos delete (non deletion vector) write are not supported in v3 only supported in v2 but pos deletes read are supported in both v2 and v3.
essentially this part of the spec
_**Position delete files must not be added to v3 tables, but existing position delete files are valid.**_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Status: Split read/write and add deletion vectors [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12958:
URL: https://github.com/apache/iceberg/pull/12958#issuecomment-2947180009
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org