You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "siddhantsangwan (via GitHub)" <gi...@apache.org> on 2023/11/02 10:54:08 UTC
[PR] HDDS-9591. Replication Manager could incorrectly use QUASI_CLOSED replicas as replication sources for CLOSED containers [ozone]
siddhantsangwan opened a new pull request, #5537:
URL: https://github.com/apache/ozone/pull/5537
## What changes were proposed in this pull request?
Even though:
1. The new RM will send close commands to QUASI_CLOSED replicas of CLOSED containers with matching sequence IDs (MismatchedReplicasHandler), and
2. It'll only replicate replicas that match the container's sequence ID (RatisUnderReplicationHandler)
there's a chance that RM ends up replicating a QUASI_CLOSED replica of a CLOSED container when other CLOSED replicas are available. This is a problem, since we want to replicate CLOSED replicas when possible.
This PR fixes the bug by only picking CLOSED replicas as sources if they're available. If they aren't available, or if the container is QUASI_CLOSED, then QUASI_CLOSED replicas are also allowed as sources.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9591
## How was this patch tested?
Added unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9591. Replication Manager could incorrectly use QUASI_CLOSED replicas as replication sources for CLOSED containers [ozone]
Posted by "sodonnel (via GitHub)" <gi...@apache.org>.
sodonnel merged PR #5537:
URL: https://github.com/apache/ozone/pull/5537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org