You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/24 13:32:19 UTC

[GitHub] [arrow] nirandaperera commented on pull request #10377: ARROW-10640: [C++] A "where" kernel to combine two arrays based on a mask

nirandaperera commented on pull request #10377:
URL: https://github.com/apache/arrow/pull/10377#issuecomment-847045029


   > Just some quick initial feedback. I think the overall approach looks fine. Testing this thoroughly will be important.
   > 
   > For a different PR I added a `DatumFromJSON` to make it easier to test functions that accept a lot of permutations of scalar/array arguments. I could pull that out separately if that would make testing easier here. (That way you don't need a lot of overloads and boilerplate to test all the possible input combinations.)
   
   That would be great @lidavidm . If you could send me the PR# that would be great! :-) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org