[jira] Commented: (QPID-1309) Build-time project name/version id for non-autoconf builds

["Ted Ross (JIRA)" <qp...@incubator.apache.org>]

    [ https://issues.apache.org/jira/browse/QPID-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636700#action_12636700 ] 

Ted Ross commented on QPID-1309:
--------------------------------

More detail...

The symbol BROKER_SASL_NAME is defined only when the configure script determines that SASL is supported.  The new file (Version.h) added with this commit dereferences this symbol without checking if it is defined.

-Ted


> Build-time project name/version id for non-autoconf builds
> ----------------------------------------------------------
>
>                 Key: QPID-1309
>                 URL: https://issues.apache.org/jira/browse/QPID-1309
>             Project: Qpid
>          Issue Type: Improvement
>          Components: C++ Broker
>    Affects Versions: M4
>         Environment: Windows w/ Visual Studio
>            Reporter: Steve Huston
>            Assignee: Steve Huston
>            Priority: Minor
>             Fix For: M4
>
>         Attachments: vers.diff
>
>
> The qpid product name and version number are currently picked up from PACKAGE_NAME, PACKAGE_VERSION via configure.ac. This mechanism doesn't exist in Windows Visual Studio. The alternative I'm proposing is to create a new file qpid/cpp/src/qpid/Version.h that takes the applicable info from config.h when present and requires it to be set when no config.h is available (such as on Windows).
> Applicable code changes are to refer to qpid::product, etc. rather than PACKAGE_NAME, etc. This requires a comment in configure.ac noting that if the name/version changes, also change it in Version.h
> Diffs are supplied.
> Is this ok, or is there some more direct way to manage this?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.