You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mi...@apache.org on 2010/08/11 00:16:33 UTC

svn commit: r984236 - /lucene/dev/trunk/lucene/src/test/org/apache/lucene/index/TestIndexWriter.java

Author: mikemccand
Date: Tue Aug 10 22:16:33 2010
New Revision: 984236

URL: http://svn.apache.org/viewvc?rev=984236&view=rev
Log:
replace TODO w/ justifying comment

Modified:
    lucene/dev/trunk/lucene/src/test/org/apache/lucene/index/TestIndexWriter.java

Modified: lucene/dev/trunk/lucene/src/test/org/apache/lucene/index/TestIndexWriter.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/src/test/org/apache/lucene/index/TestIndexWriter.java?rev=984236&r1=984235&r2=984236&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/src/test/org/apache/lucene/index/TestIndexWriter.java (original)
+++ lucene/dev/trunk/lucene/src/test/org/apache/lucene/index/TestIndexWriter.java Tue Aug 10 22:16:33 2010
@@ -1051,7 +1051,10 @@ public class TestIndexWriter extends Luc
      */
     public void testCommitOnCloseOptimize() throws IOException {
       MockRAMDirectory dir = new MockRAMDirectory();  
-      dir.setPreventDoubleWrite(false); // TODO: should this be disabled here?
+      // Must disable throwing exc on double-write: this
+      // test uses IW.rollback which easily results in
+      // writing to same file more than once
+      dir.setPreventDoubleWrite(false);
       IndexWriter writer  = new IndexWriter(dir, newIndexWriterConfig(random, TEST_VERSION_CURRENT, new MockAnalyzer()).setMaxBufferedDocs(10));
       ((LogMergePolicy) writer.getConfig().getMergePolicy()).setMergeFactor(10);
       for(int j=0;j<17;j++) {