[jira] [Commented] (GUACAMOLE-480) Cannot read property 'guac-full-name' of undefined

["Michael Jumper (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GUACAMOLE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317108#comment-16317108 ] 

Michael Jumper commented on GUACAMOLE-480:
------------------------------------------

This is a regression of GUACAMOLE-292. Though unsightly, the error itself occurs at a point where it does not have any impact on Guacamole's functionality.

> Cannot read property 'guac-full-name' of undefined
> --------------------------------------------------
>
>                 Key: GUACAMOLE-480
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-480
>             Project: Guacamole
>          Issue Type: Bug
>          Components: guacamole
>    Affects Versions: 0.9.13-incubating, 0.9.14
>            Reporter: Michael Jumper
>            Priority: Minor
>
> As mentioned in [an unrelated thread on the user@ mailing list|https://lists.apache.org/thread.html/6bf825bb63440c94c0b086d1c61df92c2b039aec701fed7af01f9ac8@%3Cuser.guacamole.apache.org%3E], Guacamole currently produces JavaScript errors under some circumstances when attempting to read attributes of the current user:
> {quote}
> {code:none}
> angular.js:11699 TypeError: Cannot read property 'guac-full-name' of undefined
>     at app.js?v=0.9.13-incubating:293
>     at angular.js:9442
>     at angular.js:13292
>     at m.$eval (angular.js:14547)
>     at m.$digest (angular.js:14363)
>     at m.$apply (angular.js:14652)
>     at l (angular.js:9734)
>     at P (angular.js:9924)
>     at XMLHttpRequest.H.onload (angular.js:9865)
> (anonymous) @ angular.js:11699
> {code}
> {quote}
> The associated JavaScript is clearly assuming that user attributes will always be returned via REST, even if empty:
> https://github.com/apache/guacamole-client/blob/00d464b51181d04e123472050833aa265dfdfee2/guacamole/src/main/webapp/app/navigation/directives/guacUserMenu.js#L104-L111
> If this assumption is valid, and it is required that users returned via REST have a defined set of attributes (even if empty), then the REST API needs to be corrected to satisfy that requirement. If this assumption is invalid, then the JavaScript needs to be corrected to not make it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)