You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "HuangZhenQiu (via GitHub)" <gi...@apache.org> on 2024/08/11 02:37:29 UTC
[PR] [FLINK-34468] bump flink version to 1.20.0 [flink-connector-cassandra]
HuangZhenQiu opened a new pull request, #29:
URL: https://github.com/apache/flink-connector-cassandra/pull/29
Bump Flink version to 1.20.0 to prepare support lineage in Cassandra connector
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34468][Connector/Cassandra] Adding support for Flink 1.20 [flink-connector-cassandra]
Posted by "echauchot (via GitHub)" <gi...@apache.org>.
echauchot commented on code in PR #29:
URL: https://github.com/apache/flink-connector-cassandra/pull/29#discussion_r1795076296
##########
flink-connector-cassandra/src/test/java/org/apache/flink/connector/cassandra/source/CassandraSourceITCase.java:
##########
@@ -197,36 +196,31 @@ protected void checkResultWithSemantic(
}
@Disabled("Not a unbounded source")
- @Override
Review Comment:
No, these methods come from the **source** base test suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34468] bump flink version to 1.20.0 [flink-connector-cassandra]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #29:
URL: https://github.com/apache/flink-connector-cassandra/pull/29#issuecomment-2282359900
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34468][Connector/Cassandra] Adding support for Flink 1.20 [flink-connector-cassandra]
Posted by "echauchot (via GitHub)" <gi...@apache.org>.
echauchot commented on PR #29:
URL: https://github.com/apache/flink-connector-cassandra/pull/29#issuecomment-2404602509
> @echauchot Thanks for the review. The major reason of removing WriteAheadSinkTestBase as the base class of CassandraConnectorITCase is WriteAheadSinkTestBase is no more accessible out side of the package "org.apache.flink.streaming.runtime.operators".
>
> Shall I remove the CassandraConnectorITCase to package namespace org.apache.flink.streaming.runtime.operators?
no I don't think the cassandra test should be moved to a flink core namespace. It looks strange to me that the visibility of WriteAheadSinkTestBase was reduced as part of the migration to Junit 5, so I [commented](https://issues.apache.org/jira/browse/FLINK-25544?focusedCommentId=17888215&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17888215) in the ticket were the change was made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34468][Connector/Cassandra] Adding support for Flink 1.20 [flink-connector-cassandra]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #29:
URL: https://github.com/apache/flink-connector-cassandra/pull/29#issuecomment-6346753197
@HuangZhenQiu Do you want to rebase / keep working on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34468][Connector/Cassandra] Adding support for Flink 1.20 [flink-connector-cassandra]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #29:
URL: https://github.com/apache/flink-connector-cassandra/pull/29#issuecomment-6411632073
Superseded by https://github.com/apache/flink-connector-cassandra/pull/47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34468][Connector/Cassandra] Adding support for Flink 1.20 [flink-connector-cassandra]
Posted by "echauchot (via GitHub)" <gi...@apache.org>.
echauchot commented on PR #29:
URL: https://github.com/apache/flink-connector-cassandra/pull/29#issuecomment-3023122680
@spandimu FYI: https://issues.apache.org/jira/browse/FLINK-38034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34468][Connector/Cassandra] Adding support for Flink 1.20 [flink-connector-cassandra]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser closed pull request #29: [FLINK-34468][Connector/Cassandra] Adding support for Flink 1.20
URL: https://github.com/apache/flink-connector-cassandra/pull/29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org