You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/07/06 01:33:41 UTC

[kudu-CR] java: refactor ITClientStress for more reusable code 

Hello Alexey Serbin,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/7360

to review the following change.

Change subject: java: refactor ITClientStress for more reusable code
......................................................................

java: refactor ITClientStress for more reusable code

Change-Id: I263b5681b52df0fa496cce2f58c0605c66810e64
---
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
1 file changed, 55 insertions(+), 30 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/7360/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I263b5681b52df0fa496cce2f58c0605c66810e64
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>

[kudu-CR] java: refactor ITClientStress for more reusable code

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: java: refactor ITClientStress for more reusable code
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7360/1/java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
File java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java:

PS1, Line 1: // Licensed to the Apache Software Foundation (ASF) under one
           : // or more contributor license agreements.  See the NOTICE file
           : // distributed with this work for additional information
           : // regarding copyright ownership.  The ASF licenses this file
           : // to you under the Apache License, Version 2.0 (the
           : // "License"); you may not use this file except in compliance
           : // with the License.  You may obtain a copy of the License at
           : //
           : //   http://www.apache.org/licenses/LICENSE-2.0
           : //
           : // Unless required by applicable law or agreed to in writing,
           : // software distributed under the License is distributed on an
           : // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
           : // KIND, either express or implied.  See the License for the
           : // specific language governing permissions and limitations
           : // under the License.
> While you are it, I wanted to clarify one stylistic nit: what sort of comme
I think we are a little inconsistent. I dont have a strong preference. Hadoop uses the C-style like Sun


-- 
To view, visit http://gerrit.cloudera.org:8080/7360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I263b5681b52df0fa496cce2f58c0605c66810e64
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] java: refactor ITClientStress for more reusable code

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: java: refactor ITClientStress for more reusable code
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I263b5681b52df0fa496cce2f58c0605c66810e64
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] java: refactor ITClientStress for more reusable code

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: java: refactor ITClientStress for more reusable code
......................................................................


Patch Set 1:

(3 comments)

lgtm, just a couple of nits and a question on the copyright headers comments style (just for my education)

http://gerrit.cloudera.org:8080/#/c/7360/1/java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
File java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java:

PS1, Line 1: // Licensed to the Apache Software Foundation (ASF) under one
           : // or more contributor license agreements.  See the NOTICE file
           : // distributed with this work for additional information
           : // regarding copyright ownership.  The ASF licenses this file
           : // to you under the Apache License, Version 2.0 (the
           : // "License"); you may not use this file except in compliance
           : // with the License.  You may obtain a copy of the License at
           : //
           : //   http://www.apache.org/licenses/LICENSE-2.0
           : //
           : // Unless required by applicable law or agreed to in writing,
           : // software distributed under the License is distributed on an
           : // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
           : // KIND, either express or implied.  See the License for the
           : // specific language governing permissions and limitations
           : // under the License.
While you are it, I wanted to clarify one stylistic nit: what sort of comments is proper for those copyright headers?  One-liner like these or c-style ones?  In Sun java sources I mostly see c-style ones.


PS1, Line 65: ;
nit: extra semicolon


PS1, Line 73: pool.awaitTermination(10, TimeUnit.SECONDS);
nit: maybe, wrap it with assertTrue() ?


-- 
To view, visit http://gerrit.cloudera.org:8080/7360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I263b5681b52df0fa496cce2f58c0605c66810e64
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] java: refactor ITClientStress for more reusable code

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.

Change subject: java: refactor ITClientStress for more reusable code
......................................................................


java: refactor ITClientStress for more reusable code

Change-Id: I263b5681b52df0fa496cce2f58c0605c66810e64
Reviewed-on: http://gerrit.cloudera.org:8080/7360
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
1 file changed, 56 insertions(+), 30 deletions(-)

Approvals:
  Jean-Daniel Cryans: Looks good to me, approved
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I263b5681b52df0fa496cce2f58c0605c66810e64
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] java: refactor ITClientStress for more reusable code

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.

Change subject: java: refactor ITClientStress for more reusable code
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I263b5681b52df0fa496cce2f58c0605c66810e64
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] java: refactor ITClientStress for more reusable code

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: java: refactor ITClientStress for more reusable code
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7360/1/java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
File java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java:

PS1, Line 65: ;
> nit: extra semicolon
Done


PS1, Line 73: pool.awaitTermination(10, TimeUnit.SECONDS);
> nit: maybe, wrap it with assertTrue() ?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I263b5681b52df0fa496cce2f58c0605c66810e64
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] java: refactor ITClientStress for more reusable code

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Jean-Daniel Cryans, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7360

to look at the new patch set (#2).

Change subject: java: refactor ITClientStress for more reusable code
......................................................................

java: refactor ITClientStress for more reusable code

Change-Id: I263b5681b52df0fa496cce2f58c0605c66810e64
---
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
1 file changed, 56 insertions(+), 30 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/7360/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I263b5681b52df0fa496cce2f58c0605c66810e64
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] java: refactor ITClientStress for more reusable code

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.

Change subject: java: refactor ITClientStress for more reusable code
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I263b5681b52df0fa496cce2f58c0605c66810e64
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No