You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2018/10/01 22:30:30 UTC

[royale-typedefs] branch develop updated: when pass first ant and then maven rat-plugin complain about files created by ant in ace/target. add the path to rat-plugin exclusions to avoid maven fail

This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-typedefs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 712b888  when pass first ant and then maven rat-plugin complain about files created by ant in ace/target. add the path to rat-plugin exclusions to avoid maven fail
712b888 is described below

commit 712b8887e8ca703cc56192d9b6ee008423e54289
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Tue Oct 2 00:30:07 2018 +0200

    when pass first ant and then maven rat-plugin complain about files created by ant in ace/target. add the path to rat-plugin exclusions to avoid maven fail
---
 pom.xml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/pom.xml b/pom.xml
index d68bffb..58b5bae 100644
--- a/pom.xml
+++ b/pom.xml
@@ -124,6 +124,7 @@
             <excludes>
                 <!-- Patch files aren't supposed to have headers -->
                 <exclude>**/*.patch</exclude>
+                <exclude>ace/target/generated-sources/**</exclude>
             </excludes>
         </configuration>
         <dependencies>


Re: [royale-typedefs] branch develop updated: when pass first ant and then maven rat-plugin complain about files created by ant in ace/target. add the path to rat-plugin exclusions to avoid maven fail

Posted by Carlos Rovira <ca...@apache.org>.
Hi Alex,
ok, I revert this
thanks

El mar., 2 oct. 2018 a las 1:34, Alex Harui (<ah...@adobe.com.invalid>)
escribió:

> I don't think this is right.  If you use Ant and then want to use Maven,
> use "ant wipe" to remove all Ant-generated files.  Maven's "clean" goal
> won't know how to remove these Ant-generated files and it is probably a bad
> idea to have them around.
>
> I have separate working copies for Ant and Maven.  Then I don't have to
> clean out the prior build's generated files.
>
> On 10/1/18, 3:30 PM, "carlosrovira@apache.org" <ca...@apache.org>
> wrote:
>
>     This is an automated email from the ASF dual-hosted git repository.
>
>     carlosrovira pushed a commit to branch develop
>     in repository
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-typedefs.git&amp;data=02%7C01%7Caharui%40adobe.com%7C505f558211ef4c8630a608d627ed7f30%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636740298327335317&amp;sdata=g%2FerykHrCqM7hFM6IoOXV%2BdvpT%2BDyf9Q1KQ%2FczNIt2Y%3D&amp;reserved=0
>
>
>     The following commit(s) were added to refs/heads/develop by this push:
>          new 712b888  when pass first ant and then maven rat-plugin
> complain about files created by ant in ace/target. add the path to
> rat-plugin exclusions to avoid maven fail
>     712b888 is described below
>
>     commit 712b8887e8ca703cc56192d9b6ee008423e54289
>     Author: Carlos Rovira <ca...@apache.org>
>     AuthorDate: Tue Oct 2 00:30:07 2018 +0200
>
>         when pass first ant and then maven rat-plugin complain about files
> created by ant in ace/target. add the path to rat-plugin exclusions to
> avoid maven fail
>     ---
>      pom.xml | 1 +
>      1 file changed, 1 insertion(+)
>
>     diff --git a/pom.xml b/pom.xml
>     index d68bffb..58b5bae 100644
>     --- a/pom.xml
>     +++ b/pom.xml
>     @@ -124,6 +124,7 @@
>                  <excludes>
>                      <!-- Patch files aren't supposed to have headers -->
>                      <exclude>**/*.patch</exclude>
>     +                <exclude>ace/target/generated-sources/**</exclude>
>                  </excludes>
>              </configuration>
>              <dependencies>
>
>
>
>

-- 
Carlos Rovira
http://about.me/carlosrovira

Re: [royale-typedefs] branch develop updated: when pass first ant and then maven rat-plugin complain about files created by ant in ace/target. add the path to rat-plugin exclusions to avoid maven fail

Posted by Alex Harui <ah...@adobe.com.INVALID>.
I don't think this is right.  If you use Ant and then want to use Maven, use "ant wipe" to remove all Ant-generated files.  Maven's "clean" goal won't know how to remove these Ant-generated files and it is probably a bad idea to have them around.

I have separate working copies for Ant and Maven.  Then I don't have to clean out the prior build's generated files.

On 10/1/18, 3:30 PM, "carlosrovira@apache.org" <ca...@apache.org> wrote:

    This is an automated email from the ASF dual-hosted git repository.
    
    carlosrovira pushed a commit to branch develop
    in repository https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-typedefs.git&amp;data=02%7C01%7Caharui%40adobe.com%7C505f558211ef4c8630a608d627ed7f30%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636740298327335317&amp;sdata=g%2FerykHrCqM7hFM6IoOXV%2BdvpT%2BDyf9Q1KQ%2FczNIt2Y%3D&amp;reserved=0
    
    
    The following commit(s) were added to refs/heads/develop by this push:
         new 712b888  when pass first ant and then maven rat-plugin complain about files created by ant in ace/target. add the path to rat-plugin exclusions to avoid maven fail
    712b888 is described below
    
    commit 712b8887e8ca703cc56192d9b6ee008423e54289
    Author: Carlos Rovira <ca...@apache.org>
    AuthorDate: Tue Oct 2 00:30:07 2018 +0200
    
        when pass first ant and then maven rat-plugin complain about files created by ant in ace/target. add the path to rat-plugin exclusions to avoid maven fail
    ---
     pom.xml | 1 +
     1 file changed, 1 insertion(+)
    
    diff --git a/pom.xml b/pom.xml
    index d68bffb..58b5bae 100644
    --- a/pom.xml
    +++ b/pom.xml
    @@ -124,6 +124,7 @@
                 <excludes>
                     <!-- Patch files aren't supposed to have headers -->
                     <exclude>**/*.patch</exclude>
    +                <exclude>ace/target/generated-sources/**</exclude>
                 </excludes>
             </configuration>
             <dependencies>