[GitHub] spark pull request #17714: [SPARK-20428][Core]REST interface about 'v1/submi...

[tnachen <gi...@git.apache.org>]

Github user tnachen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17714#discussion_r114089418
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/rest/RestSubmissionServer.scala ---
    @@ -214,15 +214,15 @@ private[rest] abstract class KillRequestServlet extends RestServlet {
       protected override def doPost(
           request: HttpServletRequest,
           response: HttpServletResponse): Unit = {
    -    val submissionId = parseSubmissionId(request.getPathInfo)
    -    val responseMessage = submissionId.map(handleKill).getOrElse {
    +    val submissionIds = parseSubmissionId(request.getPathInfo)
    --- End diff --
    
    I don't think having submission Ids parsed on the request path is a good idea.
    I would assume most use cases for batch delete is required when you have a larger number of drivers to delete (otherwise you would be fine just deleting a few one by one).
    But most URLs are length limited.
    You might be better have creating a new request for this that takes a body


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org