You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/11/24 22:55:00 UTC
[jira] [Commented] (GEODE-9782) improve package organization of geode-for-redis
[ https://issues.apache.org/jira/browse/GEODE-9782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448861#comment-17448861 ]
ASF subversion and git services commented on GEODE-9782:
--------------------------------------------------------
Commit 87e3017d57b46174ca949de69f598386bab7d4d1 in geode's branch refs/heads/develop from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=87e3017 ]
GEODE-9782: Restructure geode-for-redis module (#7142)
- Move the collections package into the data package
- Move the delta package into the data package
- Move all the Stripe classes in the services package into a new
services.locking package
- Move RegionProvider into the services package
- Move PassiveExpirationManager into the services package
- Move RedisSanctionedSerializablesService into the services package
- Move SlotAdvisor into the cluster package
- Move the cluster package into the services package
- Create a new package named "commands"
- Move Command, RedisCommandSupportLevel, and RedisCommandType
into the commands package
- Move the parameters package into the commands package
- Move the executor package into the commands package
Authored-by: Donal Evans <do...@vmware.com>
> improve package organization of geode-for-redis
> -----------------------------------------------
>
> Key: GEODE-9782
> URL: https://issues.apache.org/jira/browse/GEODE-9782
> Project: Geode
> Issue Type: Improvement
> Components: redis
> Affects Versions: 1.15.0
> Reporter: Darrel Schneider
> Assignee: Donal Evans
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> It would be nice to improve how the internals of geode-for-redis are packaged before it is released in 1.15. Try to do this when others are not active working on these classes since it could cause a bunch of conflicts. Be aware that a few of the internals may have dependencies outside of geode and those will also need to be updated. Make sure and move corresponding tests to be in the same package. Here are some ideas:
> # move the collections package into the data package
> # move the delta package into the data package
> # move all the Stripe classes in the services package into a new services.locking package
> # move RegionProvider into services
> # move PassiveExpirationManager into services
> # move RedisSanctionedSerializablesService into the services
> # move SlotAdvisor into the cluster package
> # move the cluster package into the services package (or leave it as is, also consider moving pubsub and statics into services. The "services" package is so generic lots of things could be put into it or we could get rid of it).
> # create a new package named "commands"
> # move Command, RedisCommandSupportLevel, and RedisCommandType into commands
> # move parameters into commands
> # move executor into commands
--
This message was sent by Atlassian Jira
(v8.20.1#820001)