[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #8219: Support schema permissions

[GitBox <gi...@apache.org>]

bkyryliuk commented on a change in pull request #8219: Support schema permissions 
URL: https://github.com/apache/incubator-superset/pull/8219#discussion_r344937948
 
 

 ##########
 File path: superset/connectors/druid/models.py
 ##########
 @@ -292,6 +292,10 @@ def unique_name(self) -> str:
         return self.verbose_name or self.cluster_name
 
 
+sa.event.listen(DruidCluster, "after_insert", security_manager.set_perm)
+sa.event.listen(DruidCluster, "after_update", security_manager.set_perm)
 
 Review comment:
   @willbarrett it would be a large refactor of existing functionality and all permissions model was based on using model triggers. It is definitely possible, however we should get buy-in from project maintainers & probably do it outside of this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org