[jira] [Commented] (SLING-4568) Performance: MergingResourceProvider.ParentHidingHandler adds about 30pp rendering overhead

["Joel Richard (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-4568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14483466#comment-14483466 ] 

Joel Richard commented on SLING-4568:
-------------------------------------

For some pages the overhead is even bigger. Here we have an example where it is 46pp (87%):

With ParentHidingHandler:
{code}
  50%    524
  66%    529
  75%    536
  80%    541
  90%    554
  95%    617
  98%    798
  99%    942
{code}

Without ParentHidingHandler:
{code}
  50%    280
  66%    283
  75%    286
  80%    288
  90%    295
  95%    425
  98%    454
  99%    459
{code}

> Performance: MergingResourceProvider.ParentHidingHandler adds about 30pp rendering overhead
> -------------------------------------------------------------------------------------------
>
>                 Key: SLING-4568
>                 URL: https://issues.apache.org/jira/browse/SLING-4568
>             Project: Sling
>          Issue Type: Bug
>          Components: ResourceResolver
>    Affects Versions: Resource Merger 1.2.8
>            Reporter: Joel Richard
>            Priority: Critical
>              Labels: performance
>         Attachments: SLING-4568.patch
>
>
> When I was analysing all read properties, I noticed a recurring pattern with sling:hideChildren and jcr:primaryType and that more than 40% of the read properties are sling:hideChildren. I figured out that sling:hideChildren is read for all parents in MergingResourceProvider.ParentHidingHandler and that the requests are processed 30-35pp faster just by commenting out the constructor code.
> Apache Benchmark results with normal ParentHidingHandler:
> {quote}
>   50%    272
>   66%    276
>   75%    278
>   80%    281
>   90%    289
>   95%    301
>   98%    493
>   99%    497
> {quote}
> Results with commented out ParentHidingHandler constructor: 
> {quote}
>   50%    185
>   66%    188
>   75%    191
>   80%    194
>   90%    202
>   95%    210
>   98%    333
>   99%    338
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)