[GitHub] [superset] villebro commented on a diff in pull request #21519: feat: generate consistent QueryObject whether GenericAxis is enabled or disabled

[GitBox <gi...@apache.org>]

villebro commented on code in PR #21519:
URL: https://github.com/apache/superset/pull/21519#discussion_r975154359


##########
superset-frontend/packages/superset-ui-core/src/query/getAxis.ts:
##########
@@ -16,20 +16,18 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import {
-  DTTM_ALIAS,
-  getColumnLabel,
-  isDefined,
-  QueryFormData,
-} from '@superset-ui/core';
+import { DTTM_ALIAS, getColumnLabel, QueryFormData } from '@superset-ui/core';
+
+export const isEnabledAxes = (formData: QueryFormData) => !!formData.x_axis;

Review Comment:
   Could we rename this to `isXAxisEnabled` or better yet `isXAxisSet` for clarity?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org