You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2015/10/08 17:30:29 UTC
[GitHub] flink pull request: [FLINK-2780] Remove Old Windowing Logic and AP...
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/1242
[FLINK-2780] Remove Old Windowing Logic and API
This rewrites the few examples and tests that are remaining using the new Windowing API.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink remove-old-window
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1242.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1242
----
commit ad094d36509193c06c33e19f1e06f9c42c7c4d7b
Author: Aljoscha Krettek <al...@gmail.com>
Date: 2015-10-08T09:32:18Z
[hotfix] Change result of WindowedStream ops to SingleOutputStreamOperator
commit 675014d7f0869137f1afde87a0d6c8c34cc94bf8
Author: Aljoscha Krettek <al...@gmail.com>
Date: 2015-10-04T08:33:06Z
[FLINK-2780] Remove Old Windowing Logic and API
This rewrites the few examples and tests that are remaining using the
new Windowing API.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2780] Remove Old Windowing Logic and AP...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1242#issuecomment-146608549
+1 to remove. I find it confusing as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2780] Remove Old Windowing Logic and AP...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/1242
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2780] Remove Old Windowing Logic and AP...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1242#issuecomment-146738873
+1 to get rid of the old API asap.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2780] Remove Old Windowing Logic and AP...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1242#issuecomment-146599121
This is pretty straightforward.
If no one has any reservations against removing the old API (which has been reworked into the new API) I would go ahead. The new API should support virtually everything with a mildly different syntax.
The current limbo state of having both APIs is definitely confusing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---