[GitHub] [calcite] rubenada commented on a diff in pull request #2712: [CALCITE-4999] ARRAY, MULTISET functions should return a collection of scalars if a sub-query returns 1 column

[GitBox <gi...@apache.org>]

rubenada commented on code in PR #2712:
URL: https://github.com/apache/calcite/pull/2712#discussion_r921216844


##########
core/src/main/java/org/apache/calcite/rel/core/Collect.java:
##########
@@ -132,6 +133,47 @@ public static Collect create(RelNode input,
             fieldName, input.getRowType()));
   }
 
+  /**
+   * Creates a Collect.
+   *
+   * @param input          Input relational expression
+   * @param sqlKind        SqlKind
+   * @param fieldName      Name of the sole output field
+   */
+  public static Collect create(RelNode input,

Review Comment:
   Ok, in that case we should not be calling it anymore.
   If I am not mistaken, the PR has removed all the previously existing calls (in favor of the new `create` method), but said new method calls the deprecated one (Collect.java:174): it should call the constructor directly in that line.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org