You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2025/06/22 07:51:37 UTC
[PR] chore: bump scalafmt to 3.9.7 [pekko]
He-Pin opened a new pull request, #1916:
URL: https://github.com/apache/pekko/pull/1916
Motivation:
refs: https://github.com/apache/pekko/issues/1906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: bump scalafmt to 3.9.7 [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #1916:
URL: https://github.com/apache/pekko/pull/1916#discussion_r2162882696
##########
.git-blame-ignore-revs:
##########
@@ -79,3 +79,6 @@ c44c0b7cbdab11d85176cfe062288fdcba16c56a
# Scala Steward: Reformat with scalafmt 3.8.4
f48453e60a8d11f74acc7a10d3a9da90b8acd4af
+
+# Reformat with scalafmt 3.9.7
+b152e056b5fd22e25283e48a7a96e6e6c8caf884
Review Comment:
Thanks, fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: bump scalafmt to 3.9.7 [pekko]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #1916:
URL: https://github.com/apache/pekko/pull/1916#discussion_r2160992561
##########
.git-blame-ignore-revs:
##########
@@ -79,3 +79,6 @@ c44c0b7cbdab11d85176cfe062288fdcba16c56a
# Scala Steward: Reformat with scalafmt 3.8.4
f48453e60a8d11f74acc7a10d3a9da90b8acd4af
+
+# Reformat with scalafmt 3.9.7
+dca3609b79c2c2e7dcef82e112fd8636f5e90466
Review Comment:
I think so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: bump scalafmt to 3.9.7 [pekko]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #1916:
URL: https://github.com/apache/pekko/pull/1916#discussion_r2161476919
##########
.git-blame-ignore-revs:
##########
@@ -79,3 +79,6 @@ c44c0b7cbdab11d85176cfe062288fdcba16c56a
# Scala Steward: Reformat with scalafmt 3.8.4
f48453e60a8d11f74acc7a10d3a9da90b8acd4af
+
+# Reformat with scalafmt 3.9.7
+b152e056b5fd22e25283e48a7a96e6e6c8caf884
Review Comment:
this is still here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: bump scalafmt to 3.9.7 [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #1916:
URL: https://github.com/apache/pekko/pull/1916#discussion_r2160991815
##########
.git-blame-ignore-revs:
##########
@@ -79,3 +79,6 @@ c44c0b7cbdab11d85176cfe062288fdcba16c56a
# Scala Steward: Reformat with scalafmt 3.8.4
f48453e60a8d11f74acc7a10d3a9da90b8acd4af
+
+# Reformat with scalafmt 3.9.7
+dca3609b79c2c2e7dcef82e112fd8636f5e90466
Review Comment:
Will add a new commit to fix this, dropped this commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: bump scalafmt to 3.9.7 [pekko]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof merged PR #1916:
URL: https://github.com/apache/pekko/pull/1916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: bump scalafmt to 3.9.7 [pekko]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #1916:
URL: https://github.com/apache/pekko/pull/1916#discussion_r2160938228
##########
.git-blame-ignore-revs:
##########
@@ -79,3 +79,6 @@ c44c0b7cbdab11d85176cfe062288fdcba16c56a
# Scala Steward: Reformat with scalafmt 3.8.4
f48453e60a8d11f74acc7a10d3a9da90b8acd4af
+
+# Reformat with scalafmt 3.9.7
+dca3609b79c2c2e7dcef82e112fd8636f5e90466
Review Comment:
I don't think this will work, since we have 'create a merge commit' disabled for this repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: bump scalafmt to 3.9.7 [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #1916:
URL: https://github.com/apache/pekko/pull/1916#discussion_r2160989160
##########
.git-blame-ignore-revs:
##########
@@ -79,3 +79,6 @@ c44c0b7cbdab11d85176cfe062288fdcba16c56a
# Scala Steward: Reformat with scalafmt 3.8.4
f48453e60a8d11f74acc7a10d3a9da90b8acd4af
+
+# Reformat with scalafmt 3.9.7
+dca3609b79c2c2e7dcef82e112fd8636f5e90466
Review Comment:
So I have do merge this first and then add a new commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org