You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by we...@apache.org on 2018/09/27 12:20:00 UTC

[arrow] 21/24: PARQUET-1270: Install executable tools

This is an automated email from the ASF dual-hosted git repository.

wesm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git

commit fca0625b6f67e45bba7f321e8a93be742d456455
Author: Antoine Pitrou <an...@python.org>
AuthorDate: Tue Apr 17 19:08:31 2018 +0200

    PARQUET-1270: Install executable tools
    
    "parquet_reader" and friends should be installed along with the Parquet libraries.
    
    Author: Antoine Pitrou <an...@python.org>
    
    Closes #455 from pitrou/PARQUET-1270-install-tools and squashes the following commits:
    
    44c486c [Antoine Pitrou] PARQUET-1270: Install executable tools
    
    Change-Id: I96fa2c9262716eeceddbf2d844e3805095431693
---
 cpp/tools/parquet/CMakeLists.txt | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/cpp/tools/parquet/CMakeLists.txt b/cpp/tools/parquet/CMakeLists.txt
index d473d08..0705c83 100644
--- a/cpp/tools/parquet/CMakeLists.txt
+++ b/cpp/tools/parquet/CMakeLists.txt
@@ -16,12 +16,16 @@
 # under the License.
 
 if (PARQUET_BUILD_EXECUTABLES)
-  add_executable(parquet-dump-schema parquet-dump-schema.cc)
-  target_link_libraries(parquet-dump-schema parquet_static)
+  set(EXECUTABLE_TOOLS
+    parquet-dump-schema
+    parquet_reader
+    parquet-scan)
 
-  add_executable(parquet_reader parquet_reader.cc)
-  target_link_libraries(parquet_reader parquet_static)
-
-  add_executable(parquet-scan parquet-scan.cc)
-  target_link_libraries(parquet-scan parquet_static)
+  foreach(TOOL ${EXECUTABLE_TOOLS})
+    add_executable(${TOOL} "${TOOL}.cc")
+    target_link_libraries(${TOOL} parquet_static)
+    # Avoid unsetting RPATH when installing
+    set_target_properties(${TOOL} PROPERTIES INSTALL_RPATH_USE_LINK_PATH TRUE)
+    install(TARGETS ${TOOL} RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR})
+  endforeach(TOOL)
 endif()