You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/16 03:21:59 UTC

[GitHub] [incubator-superset] codecov-io commented on pull request #11296: feat: css template add/edit modal

codecov-io commented on pull request #11296:
URL: https://github.com/apache/incubator-superset/pull/11296#issuecomment-709707492


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11296?src=pr&el=h1) Report
   > Merging [#11296](https://codecov.io/gh/apache/incubator-superset/pull/11296?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dde69d82b39feb853b9aa93976d312b9daf1c0c2?el=desc) will **increase** coverage by `1.27%`.
   > The diff coverage is `68.69%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11296/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11296?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11296      +/-   ##
   ==========================================
   + Coverage   61.50%   62.77%   +1.27%     
   ==========================================
     Files         834      442     -392     
     Lines       39562    14833   -24729     
     Branches     3610     3647      +37     
   ==========================================
   - Hits        24331     9311   -15020     
   + Misses      15050     5341    -9709     
     Partials      181      181              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `62.77% <68.69%> (+0.05%)` | :arrow_up: |
   | #python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11296?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11296/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `80.39% <47.05%> (-16.91%)` | :arrow_down: |
   | [...d/src/views/CRUD/csstemplates/CssTemplateModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11296/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlTW9kYWwudHN4) | `72.44% <72.44%> (ø)` | |
   | [superset/db\_engine\_specs/redshift.py](https://codecov.io/gh/apache/incubator-superset/pull/11296/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3JlZHNoaWZ0LnB5) | | |
   | [...tions/versions/e9df189e5c7e\_update\_base\_metrics.py](https://codecov.io/gh/apache/incubator-superset/pull/11296/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lOWRmMTg5ZTVjN2VfdXBkYXRlX2Jhc2VfbWV0cmljcy5weQ==) | | |
   | [...40e8ea\_change\_table\_schema\_description\_to\_long\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11296/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84OTExNWE0MGU4ZWFfY2hhbmdlX3RhYmxlX3NjaGVtYV9kZXNjcmlwdGlvbl90b19sb25nXy5weQ==) | | |
   | [...80aa3f04bc82\_add\_parent\_ids\_in\_dashboard\_layout.py](https://codecov.io/gh/apache/incubator-superset/pull/11296/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84MGFhM2YwNGJjODJfYWRkX3BhcmVudF9pZHNfaW5fZGFzaGJvYXJkX2xheW91dC5weQ==) | | |
   | [...ions/versions/a2d606a761d9\_adding\_favstar\_model.py](https://codecov.io/gh/apache/incubator-superset/pull/11296/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hMmQ2MDZhNzYxZDlfYWRkaW5nX2ZhdnN0YXJfbW9kZWwucHk=) | | |
   | [superset/css\_templates/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11296/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | | |
   | [superset/commands/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11296/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | | |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11296/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | | |
   | ... and [387 more](https://codecov.io/gh/apache/incubator-superset/pull/11296/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11296?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11296?src=pr&el=footer). Last update [dde69d8...ee66ef2](https://codecov.io/gh/apache/incubator-superset/pull/11296?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org