[Bug 55024] [PATCH] MIRR Formula implementation

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=55024

Cédric Walter <ce...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Cédric Walter <ce...@gmail.com> ---
I did a review, and your code is not having any error handling. I did add it
according to the specifications
(http://office.microsoft.com/en-001/excel-help/mirr-HP005209180.aspx):

* Values must contain at least one positive value and
 one negative value to calculate the modified internal rate of return.
 Otherwise, MIRR returns the #DIV/0! error value.

By the way the above specification is wrong, in an Excel sheet, i discover:

when all values are positive, excel return a #DIV/0! -> expected as stated
above
when all values are negative, excel return -1 (or -100%) -> not expected but
this behavior is implemented now and covered by tests

I also added MIRR formulas to FormulaEvalTest.xls (were missing)

you can check my changes in revision 1538795

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org