You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Rui Fan (Jira)" <ji...@apache.org> on 2023/07/05 13:56:00 UTC

[jira] [Commented] (FLINK-32362) SourceAlignment announceCombinedWatermark period task maybe lost

    [ https://issues.apache.org/jira/browse/FLINK-32362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740225#comment-17740225 ] 

Rui Fan commented on FLINK-32362:
---------------------------------

Merged via
master 1.18:   5509c61
1.17:  7219ca1
1.16:  1847b84

> SourceAlignment announceCombinedWatermark period task maybe lost
> ----------------------------------------------------------------
>
>                 Key: FLINK-32362
>                 URL: https://issues.apache.org/jira/browse/FLINK-32362
>             Project: Flink
>          Issue Type: Bug
>    Affects Versions: 1.16.0
>            Reporter: Cai Liuyang
>            Assignee: Cai Liuyang
>            Priority: Major
>              Labels: pull-request-available
>
> When we use sourcealignment，we also found there is another problem that announceCombinedWatermark may throw a exception (like  "subtask 25 is not ready yet to receive events" , this subtask maybe under failover), which will lead the period task not running any more (ThreadPoolExecutor will not schedule the period task if it throw a exception)
> I think we should increase the robustness of announceCombinedWatermark function to avoid it throw any exception (if send fail, just wait next send) (code see [https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java#L199] )



--
This message was sent by Atlassian Jira
(v8.20.10#820010)