You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/08/01 11:34:41 UTC

[GitHub] [flink] GJL commented on a change in pull request #9271: [FLINK-13384][1.9][runtime] Fix back pressure sampling for SourceStreamTask

GJL commented on a change in pull request #9271: [FLINK-13384][1.9][runtime] Fix back pressure sampling for SourceStreamTask
URL: https://github.com/apache/flink/pull/9271#discussion_r309651091
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
 ##########
 @@ -593,6 +593,10 @@ else if (current == ExecutionState.CANCELING) {
 			LOG.info("Loading JAR files for task {}.", this);
 
 			userCodeClassLoader = createUserCodeClassloader();
+
+			// make sure the user code classloader is accessible thread-locally
+			executingThread.setContextClassLoader(userCodeClassLoader);
 
 Review comment:
   > Arguably this is a separate bug fix that just wasn't discovered before.
   
   I can keep the change as a separate commit that I add before the other commits.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services