You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2020/07/06 15:43:00 UTC

[jira] [Commented] (HADOOP-17081) MetricsSystem doesn't start the sink adapters on restart

    [ https://issues.apache.org/jira/browse/HADOOP-17081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152107#comment-17152107 ] 

Hudson commented on HADOOP-17081:
---------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18411 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/18411/])
HADOOP-17081. MetricsSystem doesn't start the sink adapters on restart (github: rev 2f500e4635ea4347a55693b1a10a4a4465fe5fac)
* (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java
* (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java


> MetricsSystem doesn't start the sink adapters on restart
> --------------------------------------------------------
>
>                 Key: HADOOP-17081
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17081
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: metrics
>         Environment: NA
>            Reporter: Madhusoodan
>            Assignee: Madhusoodan
>            Priority: Minor
>             Fix For: 3.2.2, 3.3.1
>
>
> In HBase we use dynamic metrics and when a metric is removed, we have to refresh the JMX beans, since there is no API from Java to do it, a hack like stopping the metrics system and restarting it was used (Read the comment on the class [https://github.com/mmpataki/hbase/blob/master/hbase-hadoop-compat/src/main/java/org/apache/hadoop/metrics2/impl/JmxCacheBuster.java])
>  
> It calls the below APIs in the same order
>      MetricsSystem.stop
>      MetricsSystem.start
>  
> MetricsSystem.stop stops all the SinkAdapters, *but doesn't remove them from the sink list* (allSinks is the variable). When the metrics system is started again, *it is assumed that the SinkAdapters are restarted, but they are not* due to the check done in the beginning of the function register.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org