[GitHub] [spark] attilapiros commented on a change in pull request #24267: [MINOR][Streaming][Kafka]Arrange scattered config for kafka 10.

[GitBox <gi...@apache.org>]

attilapiros commented on a change in pull request #24267: [MINOR][Streaming][Kafka]Arrange scattered config for kafka 10.
URL: https://github.com/apache/spark/pull/24267#discussion_r272138826
 
 

 ##########
 File path: external/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/package.scala
 ##########
 @@ -17,7 +17,52 @@
 
 package org.apache.spark.streaming
 
+import org.apache.spark.internal.config.ConfigBuilder
+
 /**
  * Spark Integration for Kafka 0.10
  */
-package object kafka010 //scalastyle:ignore
+package object kafka010 { //scalastyle:ignore
 
 Review comment:
   As I know the reason is the digits in the object name, like here:
   
   https://github.com/apache/spark/blob/1d95dea30788b9f64c5e304d908b85936aafb238/external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/package.scala#L21-L23

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org