You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/07/03 13:34:28 UTC

[GitHub] [skywalking-rust] jmjoy commented on a diff in pull request #23: Rename crate name skywalking_rust to skywalking?

jmjoy commented on code in PR #23:
URL: https://github.com/apache/skywalking-rust/pull/23#discussion_r912488449


##########
README.md:
##########
@@ -33,8 +33,8 @@ context after the span finished.
 # Example
 
 ```rust
-use skywalking_rust::context::trace_context::TracingContext;
-use skywalking_rust::reporter::grpc::Reporter;
+use skywalking::context::trace_context::TracingContext;
+use skywalking::reporter::grpc::Reporter;

Review Comment:
   Compiling doc is means the doc generated by `cargo doc`? With 0.2.0 released, the `skywalking` will be a new crate and the name is `skywalking` in docs.rs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org