You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/02 07:52:05 UTC

[GitHub] [skywalking] kezhenxu94 commented on a diff in pull request #9725: Add APISIX metrics monitoring

kezhenxu94 commented on code in PR #9725:
URL: https://github.com/apache/skywalking/pull/9725#discussion_r985196182


##########
docs/en/concepts-and-designs/mal.md:
##########
@@ -164,7 +164,7 @@ These operations can be used to aggregate overall label dimensions or preserve d
 Example expression:
 
 ```
-instance_trace_count.sum(by: ['az'])
+instance_trace_count.sum(['az'])

Review Comment:
   This is the language spec of Groovy. The parameter name of sum function is by, which can be omitted or can be added explicitly 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org