You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2019/10/01 17:43:58 UTC
[Impala-ASF-CR] IMPALA-8960: Fix test owner privileges::test drop if exists on S3
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14334
Change subject: IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3
......................................................................
IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3
hdfs:// URIs do not work on Impala's S3 tests. The fix is to drop
the hdfs:// part of the URI. Our tests run against the default
filesystem, so dropping the hdfs:// works on both HDFS test setups
and S3 test setups.
Testing:
- Ran tests on S3
- Ran test_owner_privileges.py on HDFS locally
Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332
---
M tests/authorization/test_owner_privileges.py
M tests/common/sentry_cache_test_suite.py
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/14334/1
--
To view, visit http://gerrit.cloudera.org:8080/14334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332
Gerrit-Change-Number: 14334
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8960: Fix test owner privileges::test drop if exists on S3
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14334 )
Change subject: IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3
......................................................................
IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3
hdfs:// URIs do not work on Impala's S3 tests. The fix is to drop
the hdfs:// part of the URI. Our tests run against the default
filesystem, so dropping the hdfs:// works on both HDFS test setups
and S3 test setups.
Testing:
- Ran tests on S3
- Ran test_owner_privileges.py on HDFS locally
Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332
Reviewed-on: http://gerrit.cloudera.org:8080/14334
Reviewed-by: Michael Ho <kw...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/authorization/test_owner_privileges.py
M tests/common/sentry_cache_test_suite.py
2 files changed, 6 insertions(+), 5 deletions(-)
Approvals:
Michael Ho: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332
Gerrit-Change-Number: 14334
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] IMPALA-8960: Fix test owner privileges::test drop if exists on S3
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14334
to look at the new patch set (#2).
Change subject: IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3
......................................................................
IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3
hdfs:// URIs do not work on Impala's S3 tests. The fix is to drop
the hdfs:// part of the URI. Our tests run against the default
filesystem, so dropping the hdfs:// works on both HDFS test setups
and S3 test setups.
Testing:
- Ran tests on S3
- Ran test_owner_privileges.py on HDFS locally
Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332
---
M tests/authorization/test_owner_privileges.py
M tests/common/sentry_cache_test_suite.py
2 files changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/14334/2
--
To view, visit http://gerrit.cloudera.org:8080/14334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332
Gerrit-Change-Number: 14334
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] IMPALA-8960: Fix test owner privileges::test drop if exists on S3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14334 )
Change subject: IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332
Gerrit-Change-Number: 14334
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Oct 2019 03:27:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8960: Fix test owner privileges::test drop if exists on S3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14334 )
Change subject: IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5040/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/14334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332
Gerrit-Change-Number: 14334
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 23:12:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8960: Fix test owner privileges::test drop if exists on S3
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14334 )
Change subject: IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332
Gerrit-Change-Number: 14334
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Oct 2019 23:38:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8960: Fix test owner privileges::test drop if exists on S3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14334 )
Change subject: IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5035/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/14334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332
Gerrit-Change-Number: 14334
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 18:41:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8960: Fix test owner privileges::test drop if exists on S3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14334 )
Change subject: IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4704/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332
Gerrit-Change-Number: 14334
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Oct 2019 22:57:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8960: Fix test owner privileges::test drop if exists on S3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14334 )
Change subject: IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5038/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/14334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332
Gerrit-Change-Number: 14334
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 19:04:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8960: Fix test owner privileges::test drop if exists on S3
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14334 )
Change subject: IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14334/1/tests/authorization/test_owner_privileges.py
File tests/authorization/test_owner_privileges.py:
http://gerrit.cloudera.org:8080/#/c/14334/1/tests/authorization/test_owner_privileges.py@172
PS1, Line 172: self.execute_query("grant all on uri '/test-warehouse/libTestUdfs.so' to"
> I could be missing some details here but why not use FILESYSTEM_PREFIX inst
Good point, switched to use FILESYSTEM_PREFIX. (My understanding is that FILESYSTEM_PREFIX only impacts local filesystem these days, but it is still good to use it.)
--
To view, visit http://gerrit.cloudera.org:8080/14334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332
Gerrit-Change-Number: 14334
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Oct 2019 22:17:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8960: Fix test owner privileges::test drop if exists on S3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14334 )
Change subject: IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332
Gerrit-Change-Number: 14334
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Oct 2019 04:03:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8960: Fix test owner privileges::test drop if exists on S3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14334 )
Change subject: IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5038/
--
To view, visit http://gerrit.cloudera.org:8080/14334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332
Gerrit-Change-Number: 14334
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 22:51:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8960: Fix test owner privileges::test drop if exists on S3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14334 )
Change subject: IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5044/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/14334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332
Gerrit-Change-Number: 14334
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Oct 2019 23:44:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8960: Fix test owner privileges::test drop if exists on S3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14334 )
Change subject: IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4689/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332
Gerrit-Change-Number: 14334
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 18:24:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8960: Fix test owner privileges::test drop if exists on S3
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14334 )
Change subject: IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14334/1/tests/authorization/test_owner_privileges.py
File tests/authorization/test_owner_privileges.py:
http://gerrit.cloudera.org:8080/#/c/14334/1/tests/authorization/test_owner_privileges.py@172
PS1, Line 172: self.execute_query("grant all on uri '/test-warehouse/libTestUdfs.so' to"
I could be missing some details here but why not use FILESYSTEM_PREFIX instead ?
--
To view, visit http://gerrit.cloudera.org:8080/14334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332
Gerrit-Change-Number: 14334
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Oct 2019 19:43:18 +0000
Gerrit-HasComments: Yes