[GitHub] [arrow-rs] viirya commented on a diff in pull request #1585: Read/write nested dictionary under large list in ipc stream reader/writer

[GitBox <gi...@apache.org>]

viirya commented on code in PR #1585:
URL: https://github.com/apache/arrow-rs/pull/1585#discussion_r853269559


##########
arrow/src/ipc/reader.rs:
##########
@@ -1481,4 +1479,35 @@ mod tests {
         let output_batch = roundtrip_ipc_stream(&input_batch);
         assert_eq!(input_batch, output_batch);
     }
+
+    #[test]
+    fn test_roundtrip_stream_nested_dict_dict_in_list() {
+        // list
+        let list_data_type = DataType::List(Box::new(Field::new_dict(
+            "item",
+            DataType::Dictionary(Box::new(DataType::Int8), Box::new(DataType::Utf8)),
+            false,

Review Comment:
   Good point. Added a few nulls.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org