You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/01/07 03:40:55 UTC

[GitHub] [spark] zero323 commented on pull request #35123: [SPARK-37834][PYTHON][INFRA] Reenable length check in Python linter

zero323 commented on pull request #35123:
URL: https://github.com/apache/spark/pull/35123#issuecomment-1007116373


   > This PR reenables length check in Python linter (E501 in flake8). This was mistakenly removed from #34655.
   
   Actually, I disabled E501 in https://github.com/apache/spark/pull/34297, mostly following [line length notes](https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html?highlight=E501#line-length) from the black documentation. Specifically
   
   > However, sometimes it won’t be able to without breaking other rules. In those rare cases, auto-formatted code will exceed your allotted limit.
   
   In other cases `line-length` in black config should be respected and kind of duplicate what we have in style config.
   
   That being said, LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org