You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Paul Lindner (JIRA)" <ji...@apache.org> on 2010/07/24 01:53:51 UTC
[jira] Resolved: (SHINDIG-1394) Gadget SigningFetcher creates
invalid oauth_signature
[ https://issues.apache.org/jira/browse/SHINDIG-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-1394.
-----------------------------------
Fix Version/s: 2.0.0-RC1
Resolution: Fixed
patch applied. Thanks!
> Gadget SigningFetcher creates invalid oauth_signature
> -----------------------------------------------------
>
> Key: SHINDIG-1394
> URL: https://issues.apache.org/jira/browse/SHINDIG-1394
> Project: Shindig
> Issue Type: Bug
> Components: PHP
> Reporter: Bastian Hofmann
> Fix For: 2.0.0-RC1
>
>
> If there are any query parameters in the request the current implementation of the SigningFetcher just concats
> key=param&
> for each parameter to the base string which results in one & too much at the end of the base string.
> Fix:
> Index: php/src/gadgets/SigningFetcher.php
> ===================================================================
> 139c139
> < $newQuery = '';
> ---
> > $newQueryParts = array();
> 143c143
> < $newQuery .= urlencode($key) . '=' . urlencode($param) . '&';
> ---
> > $newQueryParts[] = urlencode($key) . '=' . urlencode($param);
> 146c146
> < $newQuery .= urlencode($key) . '=' . urlencode($elem) . '&';
> ---
> > $newQueryParts[] = urlencode($key) . '=' . urlencode($elem);
> 150a151,153
> >
> > $newQuery = implode('&', $newQueryParts);
> >
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.