You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Qifan Chen (Code Review)" <ge...@cloudera.org> on 2021/12/05 14:35:12 UTC

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Qifan Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18071


Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................

IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0

This patch addresses the check not null failure in FE by strenghening and refactoring the
logic to determine whether to apply the min/max overlap predicate and applying it in both
HdfsScanNode and RuntimeFilterGenerator.

Testing:
  Ran the core test successfully.

Change-Id: I52203e73502a35a275decb602b063982b9cad26e
---
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
2 files changed, 13 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/18071/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................


Patch Set 6:

Enhanced the outer most IF in Planner.java.


-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 6
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Dec 2021 15:59:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................

IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0

This patch addresses the check not-null failure in FE by checking
the query option PARQUET_READ_STATISTICS in the following situations:

  1) When determining whether to apply the min/max overlap predicate;
  2) When modifying query option minmax_filter_threshold and
     minmax_filtering_level for applying min/max filters to sort or
     partition columns.

When PARQUET_READ_STATISTICS is true or 1, then either will proceed.

Testing:
  1. Add a new test in TestOverlapMinMaxFilters;
  2. Ran the core test successfully.

Change-Id: I52203e73502a35a275decb602b063982b9cad26e
---
M fe/src/main/java/org/apache/impala/planner/Planner.java
M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
M testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test
3 files changed, 28 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/18071/6
-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 6
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................

IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0

This patch addresses the check not-null failure in FE by checking
the query option PARQUET_READ_STATISTICS in the following situations:

  1) When determining whether to apply the min/max overlap predicate;
  2) When modifying query option minmax_filter_threshold and
     minmax_filtering_level for applying min/max filters to sort or
     partition columns.

When PARQUET_READ_STATISTICS is true or 1, then either will proceed.

Testing:
  1. Add a new test in TestOverlapMinMaxFilters;
  2. Ran the core test successfully.

Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Reviewed-on: http://gerrit.cloudera.org:8080/18071
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/planner/Planner.java
M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
M testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test
3 files changed, 28 insertions(+), 15 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 10
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................


Patch Set 3:

Hi Qifan,
This looks good to me. Can we add e2e test to check we're not hitting this issue again?

I happen to file different patch at https://gerrit.cloudera.org/c/18069/.
I add one test there in overlap_min_max_filters.test.
Would be great to add it here if it is make sense.
I will abandon my change and we should go ahead with yours.


-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Sun, 05 Dec 2021 16:55:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................


Patch Set 4:

Hi Riza,

Many thanks for the review comment.

I modified the patch a little bit to address regress test issues and added a new test.


-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Dec 2021 04:55:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9880/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Dec 2021 14:25:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9877/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Sun, 05 Dec 2021 16:38:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Kurt Deschler (Code Review)" <ge...@cloudera.org>.
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18071/8/fe/src/main/java/org/apache/impala/planner/Planner.java
File fe/src/main/java/org/apache/impala/planner/Planner.java:

http://gerrit.cloudera.org:8080/#/c/18071/8/fe/src/main/java/org/apache/impala/planner/Planner.java@685
PS8, Line 685:         if (queryOptions.getMinmax_filter_threshold() == 0.0) {
Do we need to check for negative values here?



-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 8
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 Jan 2022 19:46:04 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................


Patch Set 8: Code-Review+1

Reapply +1.


-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 8
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 Jan 2022 16:50:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................


Patch Set 7: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7728/


-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 7
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Jan 2022 23:36:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................

IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0

This patch addresses the check not-null failure in FE by checking the query option
PARQUET_READ_STATISTICS in the following situations:
  1) When determining whether to apply the min/max overlap predicate;
  2) When modifying query option minmax_filter_threshold and minmax_filtering_level for
     applying min/max filters to sort or partition columns.

Testing:
  1. Add a new test in TestOverlapMinMaxFilters;
  2. Ran the core test successfully.

Change-Id: I52203e73502a35a275decb602b063982b9cad26e
---
M fe/src/main/java/org/apache/impala/planner/Planner.java
M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
M testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test
3 files changed, 24 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/18071/4
-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Kurt Deschler (Code Review)" <ge...@cloudera.org>.
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................


Patch Set 6: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 6
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Dec 2021 14:05:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................

IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0

This patch addresses the check not-null failure in FE by checking
the query option PARQUET_READ_STATISTICS in the following situations:

  1) When determining whether to apply the min/max overlap predicate;
  2) When modifying query option minmax_filter_threshold and
     minmax_filtering_level for applying min/max filters to sort or
     partition columns.

When PARQUET_READ_STATISTICS is true or 1, then either will proceed.

Testing:
  1. Add a new test in TestOverlapMinMaxFilters;
  2. Ran the core test successfully.

Change-Id: I52203e73502a35a275decb602b063982b9cad26e
---
M fe/src/main/java/org/apache/impala/planner/Planner.java
M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
M testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test
3 files changed, 24 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/18071/5
-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7728/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 7
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Jan 2022 17:13:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18071/8/fe/src/main/java/org/apache/impala/planner/Planner.java
File fe/src/main/java/org/apache/impala/planner/Planner.java:

http://gerrit.cloudera.org:8080/#/c/18071/8/fe/src/main/java/org/apache/impala/planner/Planner.java@685
PS8, Line 685:         if (queryOptions.getMinmax_filter_threshold() == 0.0) {
> Do we need to check for negative values here?
We should be fine. The BE limits the domain of the threshold values to [0.0, 1.0]. 

414       case TImpalaQueryOptions::MINMAX_FILTER_THRESHOLD: {                                 
 415         StringParser::ParseResult status;                                                  
 416         double val = StringParser::StringToFloat<double>(                                  
 417             value.c_str(), static_cast<int>(value.size()), &status);                       
 418         if (status != StringParser::PARSE_SUCCESS || val < 0.0 || val > 1.0) {             
 419           return Status(                                                                   
 420               Substitute("Invalid minmax filter threshold '$0'. Valid sizes are in"        
 421                          "[0.0, 1.0]",                                                     
 422                   value));                                                                 
 423         }                                                                                  
 424         query_options->__set_minmax_filter_threshold(val);                                 
 425         break;



-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 8
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Feb 2022 13:38:53 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................


Patch Set 9: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 9
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Feb 2022 14:45:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................


Patch Set 9: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 9
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Feb 2022 21:23:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................


Patch Set 9:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7799/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 9
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Feb 2022 14:45:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................


Patch Set 8: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 8
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 Jan 2022 14:25:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9878/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Dec 2021 05:14:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9881/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 6
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Dec 2021 16:20:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................


Patch Set 8:

+2 to carry Kurt and Riza's +1.


-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 8
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Feb 2022 14:44:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................


Patch Set 6: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 6
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Dec 2021 17:05:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................


Patch Set 4: Code-Review+1

Thank you, Qifan!


-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Dec 2021 07:50:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Kurt Deschler (Code Review)" <ge...@cloudera.org>.
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18071/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18071/2//COMMIT_MSG@9
PS2, Line 9: This patch addresses the check not null failure in FE by strenghening and refactoring the
Long lines



-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Sun, 05 Dec 2021 15:09:42 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................


Patch Set 7:

> Patch Set 7: Verified-1
> 
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7728/

Hit by flaky test_async_load (IMPALA-10999)


-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 7
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Jan 2022 23:50:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................


Patch Set 8:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7735/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 8
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 Jan 2022 07:49:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................


Patch Set 8: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 8
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Feb 2022 14:43:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9876/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Sun, 05 Dec 2021 14:56:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/18071 )

Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0
......................................................................

IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0

This patch addresses the check not-null failure in FE by strenghening and refactoring the
logic to determine whether to apply the min/max overlap predicate and applying it in both
HdfsScanNode and RuntimeFilterGenerator.

Testing:
  Ran the core test successfully.

Change-Id: I52203e73502a35a275decb602b063982b9cad26e
---
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M fe/src/main/java/org/apache/impala/planner/Planner.java
M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
3 files changed, 15 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/18071/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I52203e73502a35a275decb602b063982b9cad26e
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>