You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/12/26 01:33:32 UTC
[GitHub] [incubator-hudi] SteNicholas opened a new pull request #1139:
[MINOR]Optimize hudi-client module
SteNicholas opened a new pull request #1139: [MINOR]Optimize hudi-client module
URL: https://github.com/apache/incubator-hudi/pull/1139
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
Optimize hudi-client module code, including simplifing lamada expression, fixed spelling mistake, removing unused variable.
## Brief change log
- Simplify lamada expression.
- Fixed spelling mistake.
- Remove unused variable.
## Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on issue #1139:
[MINOR]Optimize hudi-client module
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1139: [MINOR]Optimize hudi-client module
URL: https://github.com/apache/incubator-hudi/pull/1139#issuecomment-570810023
Thanks. merging @leesf !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar merged pull request #1139:
[MINOR]Optimize hudi-client module
Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #1139: [MINOR]Optimize hudi-client module
URL: https://github.com/apache/incubator-hudi/pull/1139
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] cdmikechen edited a comment on issue #1139:
[MINOR]Optimize hudi-client module
Posted by GitBox <gi...@apache.org>.
cdmikechen edited a comment on issue #1139: [MINOR]Optimize hudi-client module
URL: https://github.com/apache/incubator-hudi/pull/1139#issuecomment-568963144
maybe use `git merge --squash` first to set a single commit, please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on issue #1139:
[MINOR]Optimize hudi-client module
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1139: [MINOR]Optimize hudi-client module
URL: https://github.com/apache/incubator-hudi/pull/1139#issuecomment-570010614
@SteNicholas can you please rebase and resolve the conflicts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] SteNicholas commented on issue #1139:
[MINOR]Optimize hudi-client module
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on issue #1139: [MINOR]Optimize hudi-client module
URL: https://github.com/apache/incubator-hudi/pull/1139#issuecomment-569216939
@leesf Please review the modification accoring to your comments. @vinothchandar Do you have any comments about this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf commented on issue #1139: [MINOR]Optimize
hudi-client module
Posted by GitBox <gi...@apache.org>.
leesf commented on issue #1139: [MINOR]Optimize hudi-client module
URL: https://github.com/apache/incubator-hudi/pull/1139#issuecomment-569033175
@SteNicholas Thanks for opening the PR, looks good overall, only left some minor comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf commented on a change in pull request #1139:
[MINOR]Optimize hudi-client module
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #1139: [MINOR]Optimize hudi-client module
URL: https://github.com/apache/incubator-hudi/pull/1139#discussion_r361423279
##########
File path: hudi-client/src/main/java/org/apache/hudi/config/HoodieHBaseIndexConfig.java
##########
@@ -194,6 +190,11 @@ public Builder hbaseIndexSleepMsBetweenPutBatch(int sleepMsBetweenPutBatch) {
return this;
}
+ public Builder hbaseIndexSleepMsBetweenGetBatch(int sleepMsBetweenPutBatch) {
Review comment:
sleepMsBetweenPutBatch -> sleepMsBetweenGetBatch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf commented on a change in pull request #1139:
[MINOR]Optimize hudi-client module
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #1139: [MINOR]Optimize hudi-client module
URL: https://github.com/apache/incubator-hudi/pull/1139#discussion_r361425112
##########
File path: hudi-client/src/main/java/org/apache/hudi/table/RollbackExecutor.java
##########
@@ -131,10 +130,10 @@ public RollbackExecutor(HoodieTableMetaClient metaClient, HoodieWriteConfig conf
// getFileStatus would reflect correct stats and FileNotFoundException is not thrown in
// cloud-storage : HUDI-168
Map<FileStatus, Long> filesToNumBlocksRollback = new HashMap<>();
- filesToNumBlocksRollback.put(metaClient.getFs().getFileStatus(writer.getLogFile().getPath()), 1L);
- return new Tuple2<String, HoodieRollbackStat>(rollbackRequest.getPartitionPath(),
- HoodieRollbackStat.newBuilder().withPartitionPath(rollbackRequest.getPartitionPath())
- .withRollbackBlockAppendResults(filesToNumBlocksRollback).build());
+ filesToNumBlocksRollback.put(metaClient.getFs().getFileStatus(Objects.requireNonNull(writer).getLogFile().getPath()), 1L);
Review comment:
Would replace Objects with `Preconditions`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] cdmikechen commented on issue #1139:
[MINOR]Optimize hudi-client module
Posted by GitBox <gi...@apache.org>.
cdmikechen commented on issue #1139: [MINOR]Optimize hudi-client module
URL: https://github.com/apache/incubator-hudi/pull/1139#issuecomment-568963144
maybe use `git merge --squash` first to set a single commit, pleas.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services