You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/09 05:40:40 UTC

[GitHub] [arrow] XiaokunDing commented on a change in pull request #8866: ARROW-10781:[Rust] [DataFusion] add the 'Statistics' interface in data source

XiaokunDing commented on a change in pull request #8866:
URL: https://github.com/apache/arrow/pull/8866#discussion_r539020866



##########
File path: rust/datafusion/src/datasource/datasource.rs
##########
@@ -24,6 +24,15 @@ use crate::arrow::datatypes::SchemaRef;
 use crate::error::Result;
 use crate::physical_plan::ExecutionPlan;
 
+/// The table statistics
+#[derive(Clone)]
+pub struct Statistics {
+    /// The number of table rows
+    pub num_rows: i64,

Review comment:
       Is it better to use `usize`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org