You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by fhueske <gi...@git.apache.org> on 2015/06/12 12:30:13 UTC
[GitHub] flink pull request: [FLINK-2207] Fix TableAPI conversion documenat...
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/829
[FLINK-2207] Fix TableAPI conversion documenation and further renamings for consistency
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhueske/flink fixTableDocs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/829.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #829
----
commit a961f62159e12eee0a35587474c0f798ca07ce1b
Author: Fabian Hueske <fh...@apache.org>
Date: 2015-06-12T09:36:03Z
[FLINK-2207] Fix TableAPI conversion documenation and further renamings for consistency.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2207] Fix TableAPI conversion documenat...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/829#issuecomment-111467471
Looks good but I found more old references in `table.md`:
```ack
54:val expr = input.toTable
70:val input1 = env.fromElements(...).toTable('a, 'b)
71:val input2 = env.fromElements(...).toTable('c, 'd)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2207] Fix TableAPI conversion documenat...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/829#issuecomment-111476805
Ah thanks for clarifying.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #829: [FLINK-2207] Fix TableAPI conversion documenation and furt...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/flink/pull/829
[](https://coveralls.io/builds/10332565)
Changes Unknown when pulling **e4b569505ba1c4169d39e24c9dc4ff0ca03bf992 on fhueske:fixTableDocs** into ** on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2207] Fix TableAPI conversion documenat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/829
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2207] Fix TableAPI conversion documenat...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/829#issuecomment-111475403
That's fine.
It converts a Scala `DataSet` to `Table`. Since the name of the method makes sense, it was not changed.
We changed the `TableEnvironment.toTable` into `TableEnvironment.fromDataSet`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---