[jira] [Commented] (OAK-2561) Add option to oak-run check runmode to check consistency of binary properties

["Alex Parvulescu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344754#comment-14344754 ] 

Alex Parvulescu commented on OAK-2561:
--------------------------------------

2 nitpicks:
 - the _-1 for all bytes_ is not being enforced in the _ConsistencyChecker_ class itself, making the #check contract a bit confusing. I only see a greater than zero check here [0]. It is true that negative values are turned into Long.MAX_VALUE params via the oak-run, but inside the _ConsistencyChecker_ the -1 input doesn't hold.
 - still on the same method [0], for _0_ length, the case where I want to skip reading binaries it looks like the checker acquires the inputstream but never closes it. I'd move the _blob.getNewStream()_ inside the if statement just to be on the safe side.



[0] https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/file/tooling/ConsistencyChecker.java#L219

> Add option to oak-run check runmode to check consistency of binary properties
> -----------------------------------------------------------------------------
>
>                 Key: OAK-2561
>                 URL: https://issues.apache.org/jira/browse/OAK-2561
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: run
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>             Fix For: 1.1.7
>
>
> {{oak-run check}} currently does not read binary properties. This might lead to corruptions in bulk segment to get missed. 
> We should add an option to also check binary properties. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)