You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/11/05 14:11:09 UTC

[GitHub] [superset] villebro commented on pull request #17353: feat: Drill ODBC Impersonation feature

villebro commented on pull request #17353:
URL: https://github.com/apache/superset/pull/17353#issuecomment-961927293


   Thanks for the PR @Z0ltrix ! This LGTM, but you need to address some linting issues (lines too long etc, please check the `python-lint` check). Ping @cgivre if you have time to also review this as you're most familiar with Drill.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org