You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/07/11 19:47:01 UTC

[GitHub] [lucene] stefanvodita commented on a diff in pull request #1015: [LUCENE-10629]: Add fast match query support to FacetSets

stefanvodita commented on code in PR #1015:
URL: https://github.com/apache/lucene/pull/1015#discussion_r918289599


##########
lucene/facet/src/java/org/apache/lucene/facet/facetset/MatchingFacetSetsCounts.java:
##########
@@ -52,8 +52,10 @@ public MatchingFacetSetsCounts(
       String field,
       FacetsCollector hits,
       FacetSetDecoder facetSetDecoder,
+      Query fastMatchQuery,

Review Comment:
   What do you think of preserving the constructor without `fastMatchQuery`? It would avoid adding that `null` to all existing (and possibly some future) uses.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org