[jira] [Commented] (ARROW-13408) [Packaging] Update crossbow to checkout specific git hashes

["Jonathan Keane (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-13408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384223#comment-17384223 ] 

Jonathan Keane commented on ARROW-13408:
----------------------------------------

This is not the exact same, but could be solved at the same time: Should we use {{-t}} as the short flag for both {{arrow-sha}} and {{github-token}} (and also target directory, but I think that's a bit less of a concern and didn't cause the confusion in ARROW-13379) 

{code}
@click.option('--arrow-sha', '-t', default=None,
              help='Set commit SHA or Tag name explicitly, e.g. f67a515, '
                   'apache-arrow-0.11.1.')
{code}
https://github.com/apache/arrow/blob/master/dev/archery/archery/crossbow/cli.py#L96-L98

{code} 
@click.option('--github-token', '-t', default=None,
              envvar="CROSSBOW_GITHUB_TOKEN",
              help='OAuth token for GitHub authentication')
{code}
https://github.com/apache/arrow/blob/master/dev/archery/archery/crossbow/cli.py#L33-L35

> [Packaging] Update crossbow to checkout specific git hashes
> -----------------------------------------------------------
>
>                 Key: ARROW-13408
>                 URL: https://issues.apache.org/jira/browse/ARROW-13408
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Packaging
>            Reporter: Krisztian Szucs
>            Assignee: Krisztian Szucs
>            Priority: Major
>             Fix For: 6.0.0
>
>
> Crossbow was originally designed to checkout a specific hash, but the gandiva-jars required a different checkout approach where arrow-sha is omitted. We need to update the checkout step in the macros.jinja file to use specific commit ids rather than the FETCH_HEAD.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)