You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/11 01:00:42 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #29712: [SPARK-32844][SQL] Make `DataFrameReader.table` take the specified options for datasource v1
HyukjinKwon commented on a change in pull request #29712:
URL: https://github.com/apache/spark/pull/29712#discussion_r486713438
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala
##########
@@ -190,4 +192,15 @@ object DataSourceUtils {
case LegacyBehaviorPolicy.LEGACY => RebaseDateTime.rebaseGregorianToJulianMicros
case LegacyBehaviorPolicy.CORRECTED => identity[Long]
}
+
+ private[sql] def checkDuplicateOptions(
Review comment:
We can remove `private[sql]` since execution package is already private (SPARK-16964)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org