You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/08 17:06:16 UTC
[GitHub] [beam] lukecwik commented on a diff in pull request #22182: JMH module for sdks:java:core with benchmarks for GetterBasedSchemaProvider (resolves #22181)
lukecwik commented on code in PR #22182:
URL: https://github.com/apache/beam/pull/22182#discussion_r916947148
##########
sdks/java/core/jmh/build.gradle:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+plugins { id 'org.apache.beam.module' }
+
+applyJavaNature(
+ automaticModuleName: 'org.apache.beam.sdk.jmh',
+ enableJmh: true,
+ publish: false)
+
+description = "Apache Beam :: SDKs :: Java :: Core :: JMH"
+ext.summary = "This contains JMH benchmarks for the SDK Core for Beam Java"
+
+configurations {
+ jammAgent
+}
+
+dependencies {
+ implementation project(path: ":sdks:java:core", configuration: "shadow")
+ implementation library.java.joda_time
+ runtimeOnly library.java.slf4j_jdk14
+ jammAgent library.java.jamm
+}
+
+jmh {
+ configurations.jammAgent.resolvedConfiguration.files.each {
+ jvmArgs '-javaagent:' + it
+ }
+}
+
+jmhTest {
+ configurations.jammAgent.resolvedConfiguration.files.each {
+ jvmArgs '-javaagent:' + it
+ }
+}
+
Review Comment:
```suggestion
```
I don't think you need to add jamm as a java agent. It is only used in the SDK harness for measuring object sizes.
##########
sdks/java/core/jmh/build.gradle:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+plugins { id 'org.apache.beam.module' }
+
+applyJavaNature(
+ automaticModuleName: 'org.apache.beam.sdk.jmh',
+ enableJmh: true,
+ publish: false)
+
+description = "Apache Beam :: SDKs :: Java :: Core :: JMH"
+ext.summary = "This contains JMH benchmarks for the SDK Core for Beam Java"
+
+configurations {
+ jammAgent
+}
+
Review Comment:
```suggestion
```
I don't think you need to add jamm as a java agent. It is only used in the SDK harness for measuring object sizes.
##########
sdks/java/core/jmh/src/main/java/org/apache/beam/sdk/schemas/RowBundle.java:
##########
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.schemas;
+
+import static java.util.stream.Collectors.toList;
+import static java.util.stream.Collectors.toMap;
+import static java.util.stream.IntStream.range;
+
+import java.nio.charset.StandardCharsets;
+import java.util.Map;
+import java.util.function.BiConsumer;
+import java.util.function.Function;
+import java.util.stream.IntStream;
+import org.apache.beam.sdk.transforms.SerializableFunction;
+import org.apache.beam.sdk.values.Row;
+import org.apache.beam.sdk.values.RowWithGetters;
+import org.apache.beam.sdk.values.RowWithStorage;
+import org.apache.beam.sdk.values.TypeDescriptor;
+import org.joda.time.DateTime;
+import org.joda.time.Duration;
+import org.joda.time.Instant;
+import org.openjdk.jmh.annotations.Level;
+import org.openjdk.jmh.annotations.Param;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.Setup;
+import org.openjdk.jmh.annotations.State;
+import org.openjdk.jmh.infra.Blackhole;
+
+/**
+ * Bundle of rows according to the configured {@link Factory} as input for benchmarks.
+ *
+ * <p>The rows are created during {@link #setup()} to exclude initialization costs from the
+ * measurement. To prevent unintended cache hits in {@link RowWithGetters}, a new bundle of rows
+ * must be generated before every invocation.
+ *
+ * <p>Setup per {@link Level#Invocation} has considerable drawbacks. Though, given that processing
+ * bundles of rows (n={@link #bundleSize}) takes well above 1 ms, each individual invocation can be
+ * adequately timestamped without risking generating wrong results.
+ */
+@State(Scope.Benchmark)
+public class RowBundle {
+ @SuppressWarnings("ImmutableEnumChecker") // false positive
+ public enum Action {
+ /**
+ * Write field to object using {@link
+ * GetterBasedSchemaProvider#fromRowFunction(TypeDescriptor)}.
+ *
+ * <p>Use {@link RowWithStorage} to bypass optimizations in RowWithGetters for writes.
+ */
+ WRITE(Factory::createWithStorage),
+
+ /**
+ * Read field from {@link RowWithGetters} provided by {@link
+ * GetterBasedSchemaProvider#toRowFunction(TypeDescriptor)}.
+ */
+ READ_ONCE(Factory::createWithGetter),
+
+ /**
+ * Repeatedly (3x) read field from {@link RowWithGetters} provided by {@link
+ * GetterBasedSchemaProvider#toRowFunction(TypeDescriptor)}.
+ */
+ READ_REPEATED(Factory::createWithGetter);
+
+ final Function<SchemaCoder<?>, Factory<Row>> factoryProvider;
+
+ Action(Function<SchemaCoder<?>, Factory<Row>> factoryProvider) {
+ this.factoryProvider = factoryProvider;
+ }
+ }
+
+ private static final SchemaRegistry REGISTRY = SchemaRegistry.createDefault();
+
+ private final SchemaCoder<?> coder;
+ private final Sink<Row> sink;
+ private Factory<Row> factory;
+
+ protected Row[] rows;
+
+ @Param("100000")
+ int bundleSize;
+
+ @Param({"READ_ONCE", "WRITE"})
+ Action action;
+
+ public RowBundle() {
+ this(null); // unused, just to prevent warnings
+ }
Review Comment:
Why do you need this constructor?
##########
sdks/java/core/jmh/src/main/java/org/apache/beam/sdk/schemas/RowBundle.java:
##########
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.schemas;
+
+import static java.util.stream.Collectors.toList;
+import static java.util.stream.Collectors.toMap;
+import static java.util.stream.IntStream.range;
+
+import java.nio.charset.StandardCharsets;
+import java.util.Map;
+import java.util.function.BiConsumer;
+import java.util.function.Function;
+import java.util.stream.IntStream;
+import org.apache.beam.sdk.transforms.SerializableFunction;
+import org.apache.beam.sdk.values.Row;
+import org.apache.beam.sdk.values.RowWithGetters;
+import org.apache.beam.sdk.values.RowWithStorage;
+import org.apache.beam.sdk.values.TypeDescriptor;
+import org.joda.time.DateTime;
+import org.joda.time.Duration;
+import org.joda.time.Instant;
+import org.openjdk.jmh.annotations.Level;
+import org.openjdk.jmh.annotations.Param;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.Setup;
+import org.openjdk.jmh.annotations.State;
+import org.openjdk.jmh.infra.Blackhole;
+
+/**
+ * Bundle of rows according to the configured {@link Factory} as input for benchmarks.
+ *
+ * <p>The rows are created during {@link #setup()} to exclude initialization costs from the
+ * measurement. To prevent unintended cache hits in {@link RowWithGetters}, a new bundle of rows
+ * must be generated before every invocation.
+ *
+ * <p>Setup per {@link Level#Invocation} has considerable drawbacks. Though, given that processing
+ * bundles of rows (n={@link #bundleSize}) takes well above 1 ms, each individual invocation can be
+ * adequately timestamped without risking generating wrong results.
+ */
+@State(Scope.Benchmark)
+public class RowBundle {
+ @SuppressWarnings("ImmutableEnumChecker") // false positive
+ public enum Action {
+ /**
+ * Write field to object using {@link
+ * GetterBasedSchemaProvider#fromRowFunction(TypeDescriptor)}.
+ *
+ * <p>Use {@link RowWithStorage} to bypass optimizations in RowWithGetters for writes.
+ */
+ WRITE(Factory::createWithStorage),
+
+ /**
+ * Read field from {@link RowWithGetters} provided by {@link
+ * GetterBasedSchemaProvider#toRowFunction(TypeDescriptor)}.
+ */
+ READ_ONCE(Factory::createWithGetter),
+
+ /**
+ * Repeatedly (3x) read field from {@link RowWithGetters} provided by {@link
+ * GetterBasedSchemaProvider#toRowFunction(TypeDescriptor)}.
+ */
+ READ_REPEATED(Factory::createWithGetter);
+
+ final Function<SchemaCoder<?>, Factory<Row>> factoryProvider;
+
+ Action(Function<SchemaCoder<?>, Factory<Row>> factoryProvider) {
+ this.factoryProvider = factoryProvider;
+ }
+ }
+
+ private static final SchemaRegistry REGISTRY = SchemaRegistry.createDefault();
+
+ private final SchemaCoder<?> coder;
+ private final Sink<Row> sink;
+ private Factory<Row> factory;
+
+ protected Row[] rows;
+
+ @Param("100000")
+ int bundleSize;
+
+ @Param({"READ_ONCE", "WRITE"})
Review Comment:
READ_REPEATED?
##########
sdks/java/core/jmh/src/main/java/org/apache/beam/sdk/schemas/RowBundle.java:
##########
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.schemas;
+
+import static java.util.stream.Collectors.toList;
+import static java.util.stream.Collectors.toMap;
+import static java.util.stream.IntStream.range;
+
+import java.nio.charset.StandardCharsets;
+import java.util.Map;
+import java.util.function.BiConsumer;
+import java.util.function.Function;
+import java.util.stream.IntStream;
+import org.apache.beam.sdk.transforms.SerializableFunction;
+import org.apache.beam.sdk.values.Row;
+import org.apache.beam.sdk.values.RowWithGetters;
+import org.apache.beam.sdk.values.RowWithStorage;
+import org.apache.beam.sdk.values.TypeDescriptor;
+import org.joda.time.DateTime;
+import org.joda.time.Duration;
+import org.joda.time.Instant;
+import org.openjdk.jmh.annotations.Level;
+import org.openjdk.jmh.annotations.Param;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.Setup;
+import org.openjdk.jmh.annotations.State;
+import org.openjdk.jmh.infra.Blackhole;
+
+/**
+ * Bundle of rows according to the configured {@link Factory} as input for benchmarks.
+ *
+ * <p>The rows are created during {@link #setup()} to exclude initialization costs from the
+ * measurement. To prevent unintended cache hits in {@link RowWithGetters}, a new bundle of rows
+ * must be generated before every invocation.
+ *
+ * <p>Setup per {@link Level#Invocation} has considerable drawbacks. Though, given that processing
+ * bundles of rows (n={@link #bundleSize}) takes well above 1 ms, each individual invocation can be
+ * adequately timestamped without risking generating wrong results.
+ */
+@State(Scope.Benchmark)
+public class RowBundle {
+ @SuppressWarnings("ImmutableEnumChecker") // false positive
+ public enum Action {
+ /**
+ * Write field to object using {@link
+ * GetterBasedSchemaProvider#fromRowFunction(TypeDescriptor)}.
+ *
+ * <p>Use {@link RowWithStorage} to bypass optimizations in RowWithGetters for writes.
+ */
+ WRITE(Factory::createWithStorage),
+
+ /**
+ * Read field from {@link RowWithGetters} provided by {@link
+ * GetterBasedSchemaProvider#toRowFunction(TypeDescriptor)}.
+ */
+ READ_ONCE(Factory::createWithGetter),
+
+ /**
+ * Repeatedly (3x) read field from {@link RowWithGetters} provided by {@link
Review Comment:
Why 3x?
Is this the amount of reads seen in practice when a field is read multiple times?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org