You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Ivan Mitic (JIRA)" <ji...@apache.org> on 2012/05/18 23:59:07 UTC
[jira] [Created] (HADOOP-8411) TestStorageDirecotyFailure,
TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
Ivan Mitic created HADOOP-8411:
----------------------------------
Summary: TestStorageDirecotyFailure, TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
Key: HADOOP-8411
URL: https://issues.apache.org/jira/browse/HADOOP-8411
Project: Hadoop Common
Issue Type: Bug
Components: util
Affects Versions: 1.1.0
Reporter: Ivan Mitic
Jira tracking failures from the summary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8411) TestStorageDirecotyFailure,
TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
Posted by "Ivan Mitic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Mitic updated HADOOP-8411:
-------------------------------
Attachment: HADOOP-8411-branch-1-win.patch
Attaching updated patch.
> TestStorageDirecotyFailure, TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
> ------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8411
> URL: https://issues.apache.org/jira/browse/HADOOP-8411
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 1.1.0
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-8411-branch-1-win.patch, HADOOP-8411-branch-1-win.patch, HADOOP-8411-branch-1-win.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Jira tracking failures from the summary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8411) TestStorageDirecotyFailure,
TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280363#comment-13280363 ]
Bikas Saha commented on HADOOP-8411:
------------------------------------
If the target always exists then perhaps rename the function to assert that?
> TestStorageDirecotyFailure, TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
> ------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8411
> URL: https://issues.apache.org/jira/browse/HADOOP-8411
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 1.1.0
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-8411-branch-1-win.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Jira tracking failures from the summary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8411) TestStorageDirecotyFailure,
TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
Posted by "Ivan Mitic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283748#comment-13283748 ]
Ivan Mitic commented on HADOOP-8411:
------------------------------------
Daryn, Bikas, have I addressed all of your concerns in the latest patch?
> TestStorageDirecotyFailure, TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
> ------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8411
> URL: https://issues.apache.org/jira/browse/HADOOP-8411
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 1.1.0
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-8411-branch-1-win.patch, HADOOP-8411-branch-1-win.patch, HADOOP-8411-branch-1-win.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Jira tracking failures from the summary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8411) TestStorageDirecotyFailure,
TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
Posted by "Ivan Mitic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280499#comment-13280499 ]
Ivan Mitic commented on HADOOP-8411:
------------------------------------
Good point, will use Java's rename in case the target does not exist.
> TestStorageDirecotyFailure, TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
> ------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8411
> URL: https://issues.apache.org/jira/browse/HADOOP-8411
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 1.1.0
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-8411-branch-1-win.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Jira tracking failures from the summary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8411) TestStorageDirecotyFailure,
TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
Posted by "Ivan Mitic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Mitic updated HADOOP-8411:
-------------------------------
Attachment: HADOOP-8411-branch-1-win.patch
Attaching new revision of the patch.
> TestStorageDirecotyFailure, TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
> ------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8411
> URL: https://issues.apache.org/jira/browse/HADOOP-8411
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 1.1.0
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-8411-branch-1-win.patch, HADOOP-8411-branch-1-win.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Jira tracking failures from the summary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8411) TestStorageDirecotyFailure,
TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280362#comment-13280362 ]
Bikas Saha commented on HADOOP-8411:
------------------------------------
bq. renameAtomicWithOverride()
This handles the case of overriding an existing target with a new source file. What if target does not exist and rename should pass on its own?
> TestStorageDirecotyFailure, TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
> ------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8411
> URL: https://issues.apache.org/jira/browse/HADOOP-8411
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 1.1.0
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-8411-branch-1-win.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Jira tracking failures from the summary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8411) TestStorageDirecotyFailure,
TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280528#comment-13280528 ]
Daryn Sharp commented on HADOOP-8411:
-------------------------------------
I don't think {{import org.apache.tools.ant.util.FileUtils}} is needed?
{{File tmpTargetFile = new File(target.getParentFile(), "original.tmp");}} will cause collisions if files are concurrently renamed in the same directory. I'd do something more like {{new File(target+".tmp")}}.
Is {{renameAtomicWithOverride}} intended to handle the issue later commented "Files that are currently in use cannot be deleted on Windows"? If so, won't the delete of the renamed target always fail?
I'm a bit leery of adding windows-specific behavior because those of us not running on windows may unknowingly break it. Would it be possible to commonize the behavior by trying to do the rename, if that fails, try to do the double rename? I'd also tag the renamed target with {{File#deleteOnExit()}} just in case an exception happens.
Is the windows conditional in {{TestStorageDirectoryFailure}} needed? It seems like it should work for all platforms?
Have you tested that the ugi username changes in {{TestWebHdfsUrl}} won't break non-windows platforms?
> TestStorageDirecotyFailure, TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
> ------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8411
> URL: https://issues.apache.org/jira/browse/HADOOP-8411
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 1.1.0
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-8411-branch-1-win.patch, HADOOP-8411-branch-1-win.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Jira tracking failures from the summary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8411) TestStorageDirecotyFailure,
TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
Posted by "Ivan Mitic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281743#comment-13281743 ]
Ivan Mitic commented on HADOOP-8411:
------------------------------------
Thanks Bikas. I took a brief look, and I see some reported issues on memory leaks that date a few years back. I don't have a strong opinion either way, and given that this is not a mainstream scenario, my take is to keep it. Let me know if you think otherwise.
> TestStorageDirecotyFailure, TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
> ------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8411
> URL: https://issues.apache.org/jira/browse/HADOOP-8411
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 1.1.0
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-8411-branch-1-win.patch, HADOOP-8411-branch-1-win.patch, HADOOP-8411-branch-1-win.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Jira tracking failures from the summary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8411) TestStorageDirecotyFailure,
TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
Posted by "Ivan Mitic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Mitic updated HADOOP-8411:
-------------------------------
Attachment: HADOOP-8411-branch-1-win.patch
Attaching patch.
> TestStorageDirecotyFailure, TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
> ------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8411
> URL: https://issues.apache.org/jira/browse/HADOOP-8411
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 1.1.0
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-8411-branch-1-win.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Jira tracking failures from the summary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8411) TestStorageDirecotyFailure,
TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sanjay Radia updated HADOOP-8411:
---------------------------------
Attachment: HADOOP-8411-2-branch-1-win.patch
Updated patch run through dos2unix
> TestStorageDirecotyFailure, TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
> ------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8411
> URL: https://issues.apache.org/jira/browse/HADOOP-8411
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 1.1.0
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-8411-2-branch-1-win.patch, HADOOP-8411-branch-1-win.patch, HADOOP-8411-branch-1-win.patch, HADOOP-8411-branch-1-win.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Jira tracking failures from the summary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8411) TestStorageDirecotyFailure,
TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
Posted by "Ivan Mitic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281349#comment-13281349 ]
Ivan Mitic commented on HADOOP-8411:
------------------------------------
Thanks Daryn, answers inline.
I don't think import org.apache.tools.ant.util.FileUtils is needed?
@Daryn: Fixed in next patch, thanks
File tmpTargetFile = new File(target.getParentFile(), "original.tmp"); will cause collisions if files are concurrently renamed in the same directory. I'd do something more like new File(target+".tmp").
@Daryn: It does not seem it can happen in this context, but it is a good change, so fixed.
Is renameAtomicWithOverride intended to handle the issue later commented "Files that are currently in use cannot be deleted on Windows"? If so, won't the delete of the renamed target always fail?
@Daryn: Actually not. Renaming into the existing file fails on Windows. In this case, while truncating the log, we are trying the rename the truncated tmp log file into the actual log (which might exist) in which case rename fails.
I'm a bit leery of adding windows-specific behavior because those of us not running on windows may unknowingly break it. Would it be possible to commonize the behavior by trying to do the rename, if that fails, try to do the double rename? I'd also tag the renamed target with File#deleteOnExit() just in case an exception happens.
@Daryn: In this case, I don't think I can get around with calling rename twice and I have to do this dance with files. Though, your concerns are valid, and are something we are also thinking about. At this point, goal is to make everything run on Windows, and as we move forward we'll see what can/should be improved.
@Daryn: It makes sense to add tmpTargetFile.deleteOnExit() if regular delete fails, thanks.
Is the windows conditional in TestStorageDirectoryFailure needed? It seems like it should work for all platforms?
@Daryn: I don't think it is required. It might make sense to leave it and test this scenario, as on Unix like systems users can go ahead and delete these files (OS is not preventing them from doing so).
Have you tested that the ugi username changes in TestWebHdfsUrl won't break non-windows platforms?
@Daryn: Yes I have. Also, if you take a look at SecurityUtil.replacePattern { ...fqdn.toLowerCase() ... } you can see where the mismatch comes from.
> TestStorageDirecotyFailure, TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
> ------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8411
> URL: https://issues.apache.org/jira/browse/HADOOP-8411
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 1.1.0
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-8411-branch-1-win.patch, HADOOP-8411-branch-1-win.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Jira tracking failures from the summary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8411) TestStorageDirecotyFailure,
TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286596#comment-13286596 ]
Daryn Sharp commented on HADOOP-8411:
-------------------------------------
+1 I think it looks ok.
> TestStorageDirecotyFailure, TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
> ------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8411
> URL: https://issues.apache.org/jira/browse/HADOOP-8411
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 1.1.0
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-8411-branch-1-win.patch, HADOOP-8411-branch-1-win.patch, HADOOP-8411-branch-1-win.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Jira tracking failures from the summary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8411) TestStorageDirecotyFailure,
TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285236#comment-13285236 ]
Bikas Saha commented on HADOOP-8411:
------------------------------------
Looks ok to me. Thanks!
> TestStorageDirecotyFailure, TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
> ------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8411
> URL: https://issues.apache.org/jira/browse/HADOOP-8411
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 1.1.0
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-8411-branch-1-win.patch, HADOOP-8411-branch-1-win.patch, HADOOP-8411-branch-1-win.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Jira tracking failures from the summary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8411) TestStorageDirecotyFailure,
TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281360#comment-13281360 ]
Bikas Saha commented on HADOOP-8411:
------------------------------------
please see some of the comments around File#deleteOnExit() on Google before deciding either ways. it seems that this has some undesirable characteristics.
> TestStorageDirecotyFailure, TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
> ------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8411
> URL: https://issues.apache.org/jira/browse/HADOOP-8411
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 1.1.0
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-8411-branch-1-win.patch, HADOOP-8411-branch-1-win.patch, HADOOP-8411-branch-1-win.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Jira tracking failures from the summary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HADOOP-8411) TestStorageDirecotyFailure,
TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sanjay Radia resolved HADOOP-8411.
----------------------------------
Resolution: Fixed
Target Version/s: HADOOP-1-Windows (was: 1.1.0)
Committed patch. Thanks Ivan.
> TestStorageDirecotyFailure, TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
> ------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8411
> URL: https://issues.apache.org/jira/browse/HADOOP-8411
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 1.1.0
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-8411-2-branch-1-win.patch, HADOOP-8411-branch-1-win.patch, HADOOP-8411-branch-1-win.patch, HADOOP-8411-branch-1-win.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Jira tracking failures from the summary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8411) TestStorageDirecotyFailure,
TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
Posted by "Ivan Mitic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281356#comment-13281356 ]
Ivan Mitic commented on HADOOP-8411:
------------------------------------
One correction:
Have you tested that the ugi username changes in TestWebHdfsUrl won't break non-windows platforms?
@Daryn: Missmatch comes from: WebHdfsFileSystem.toUrl -> new UserParam(ugi) -> ugi.getShortUserName(). And yes, the test passes on Linux.
> TestStorageDirecotyFailure, TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
> ------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8411
> URL: https://issues.apache.org/jira/browse/HADOOP-8411
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 1.1.0
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-8411-branch-1-win.patch, HADOOP-8411-branch-1-win.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Jira tracking failures from the summary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8411) TestStorageDirecotyFailure,
TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280520#comment-13280520 ]
Bikas Saha commented on HADOOP-8411:
------------------------------------
Thanks! That works.
Sorry I forgot to add this in the initial comment. I get confused with the name renameAtomicWithOverride. The method is trying to rename a source to a potentially existing destination, as far as I see it.
> TestStorageDirecotyFailure, TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
> ------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8411
> URL: https://issues.apache.org/jira/browse/HADOOP-8411
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 1.1.0
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-8411-branch-1-win.patch, HADOOP-8411-branch-1-win.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Jira tracking failures from the summary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8411) TestStorageDirecotyFailure,
TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sanjay Radia updated HADOOP-8411:
---------------------------------
Assignee: Ivan Mitic
> TestStorageDirecotyFailure, TestTaskLogsTruncater, TestWebHdfsUrl and TestSecurityUtil fail on Windows
> ------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8411
> URL: https://issues.apache.org/jira/browse/HADOOP-8411
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 1.1.0
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Jira tracking failures from the summary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira