You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whimsical.apache.org by Craig Russell <ap...@gmail.com> on 2019/05/09 03:48:40 UTC
Secretary workbench health check?
I am seeing three documents sent to secretary that have not appeared in the secretary workbench.
All times PDT (GMT -7)
Tuesday 8:54 PM
Wednesday 12:05 AM
Wednesday 12:23 PM
The whimsy user interface seems to be ok. Any ideas what happened to these three ICLAs?
Thanks,
Craig
Craig L Russell
clr@apache.org
Re: Secretary workbench health check?
Posted by Sam Ruby <ru...@intertwingly.net>.
On Thu, May 9, 2019 at 12:02 PM Craig Russell <ap...@gmail.com> wrote:
>
> Hi Sebb,
>
> Thanks for taking care of this important issue.
>
> Is there any takeaway to avoid this in future? It has happened a small number of times in the past, and it would be good to know if you think it's solved for now or solved until the next time.
Sebb isolated the problem to a recent change I made to a dependency,
namely ruby2js. Ruby has a method named merge than older versions of
JavaScript didn't have a good equivalent, but newer versions do. When
I added support for that method, it broke a class in the secretary
workbench that had defined a method named merge. I fixed ruby2js to
give priority to locally defined methods over language builtins, and
added a test case.
- Sam Ruby
> Thanks,
>
> Craig
>
> > On May 9, 2019, at 4:05 AM, sebb <se...@gmail.com> wrote:
> >
> > On Thu, 9 May 2019 at 11:03, sebb <sebbaz@gmail.com <ma...@gmail.com>> wrote:
> >>
> >> On Thu, 9 May 2019 at 10:05, sebb <se...@gmail.com> wrote:
> >>>
> >>> On Thu, 9 May 2019 at 04:48, Craig Russell <ap...@gmail.com> wrote:
> >>>>
> >>>> I am seeing three documents sent to secretary that have not appeared in the secretary workbench.
> >>>
> >>> Investigating ...
> >>>
> >>> I think I have found the messages to which you refer:
> >>>
> >>>> All times PDT (GMT -7)
> >>>> Tuesday 8:54 PM
> >>> https://mail-search.apache.org/members/private-arch/officers-secretary/201905.mbox/%3cCAKpzXcZ4OUUdg3y+dS1snfGXhP=qddAMS_efOjjKWr4sGZ0-Rg@mail.gmail.com%3e
> >>>
> >>> Message-ID: <CA...@mail.gmail.com>
> >>>
> >>>> Wednesday 12:05 AM
> >>> https://mail-search.apache.org/members/private-arch/officers-secretary/201905.mbox/%3c87daa111-31e1-410a-8add-a5812ad9fc90@Spark%3e
> >>>
> >>> Message-ID: <87...@Spark>
> >>>
> >>>> Wednesday 12:23 PM
> >>> https://mail-search.apache.org/members/private-arch/officers-secretary/201905.mbox/%3cCA+AaKM_4z+4nJ-wBiXnz4o9AvisSzn-2nvK4KUhuqaYuXfSYhA@mail.gmail.com%3e
> >>>
> >>> Message-ID: <CA...@mail.gmail.com>
> >>>
> >>>>
> >>>> The whimsy user interface seems to be ok. Any ideas what happened to these three ICLAs?
> >>>
> >>> About to look on Whimsy
> >>
> >> When I tried loading the 201905.yml file on my local system, all the
> >> messages showed up (as well as some others).
> >>
> >> The messages all appear in the JSON file, which is what drives the display:
> >>
> >> https://whimsy.apache.org/secretary/workbench/201905
> >>
> >> I don't yet know why the live site thinks there are no messages left
> >> to process, whereas my local copy displays several entries.
> >>
> >> The JSON is the same on my system, so it looks to be an issue with the
> >> Javascript.
> >> I will add some console logging to try and trace what is happening.
> >
> > It seems that the live installation generates different Javascript
> > from my local version.
> > In particular, it handles self.merge differently; not entirely sure
> > what the code is trying to do.
> > I renamed the method and it all seems to be working now.
> >
> > I think my system uses ruby2js 3.0.7 whereas whimsy-vm4 uses 3.1.0; I
> > assume that may be the cause.
> >
> >>>> Thanks,
> >>>>
> >>>> Craig
> >>>>
> >>>> Craig L Russell
> >>>> clr@apache.org <ma...@apache.org>
> Craig L Russell
> clr@apache.org
>
Re: Secretary workbench health check?
Posted by Craig Russell <ap...@gmail.com>.
Hi Sebb,
Thanks for taking care of this important issue.
Is there any takeaway to avoid this in future? It has happened a small number of times in the past, and it would be good to know if you think it's solved for now or solved until the next time.
Thanks,
Craig
> On May 9, 2019, at 4:05 AM, sebb <se...@gmail.com> wrote:
>
> On Thu, 9 May 2019 at 11:03, sebb <sebbaz@gmail.com <ma...@gmail.com>> wrote:
>>
>> On Thu, 9 May 2019 at 10:05, sebb <se...@gmail.com> wrote:
>>>
>>> On Thu, 9 May 2019 at 04:48, Craig Russell <ap...@gmail.com> wrote:
>>>>
>>>> I am seeing three documents sent to secretary that have not appeared in the secretary workbench.
>>>
>>> Investigating ...
>>>
>>> I think I have found the messages to which you refer:
>>>
>>>> All times PDT (GMT -7)
>>>> Tuesday 8:54 PM
>>> https://mail-search.apache.org/members/private-arch/officers-secretary/201905.mbox/%3cCAKpzXcZ4OUUdg3y+dS1snfGXhP=qddAMS_efOjjKWr4sGZ0-Rg@mail.gmail.com%3e
>>>
>>> Message-ID: <CA...@mail.gmail.com>
>>>
>>>> Wednesday 12:05 AM
>>> https://mail-search.apache.org/members/private-arch/officers-secretary/201905.mbox/%3c87daa111-31e1-410a-8add-a5812ad9fc90@Spark%3e
>>>
>>> Message-ID: <87...@Spark>
>>>
>>>> Wednesday 12:23 PM
>>> https://mail-search.apache.org/members/private-arch/officers-secretary/201905.mbox/%3cCA+AaKM_4z+4nJ-wBiXnz4o9AvisSzn-2nvK4KUhuqaYuXfSYhA@mail.gmail.com%3e
>>>
>>> Message-ID: <CA...@mail.gmail.com>
>>>
>>>>
>>>> The whimsy user interface seems to be ok. Any ideas what happened to these three ICLAs?
>>>
>>> About to look on Whimsy
>>
>> When I tried loading the 201905.yml file on my local system, all the
>> messages showed up (as well as some others).
>>
>> The messages all appear in the JSON file, which is what drives the display:
>>
>> https://whimsy.apache.org/secretary/workbench/201905
>>
>> I don't yet know why the live site thinks there are no messages left
>> to process, whereas my local copy displays several entries.
>>
>> The JSON is the same on my system, so it looks to be an issue with the
>> Javascript.
>> I will add some console logging to try and trace what is happening.
>
> It seems that the live installation generates different Javascript
> from my local version.
> In particular, it handles self.merge differently; not entirely sure
> what the code is trying to do.
> I renamed the method and it all seems to be working now.
>
> I think my system uses ruby2js 3.0.7 whereas whimsy-vm4 uses 3.1.0; I
> assume that may be the cause.
>
>>>> Thanks,
>>>>
>>>> Craig
>>>>
>>>> Craig L Russell
>>>> clr@apache.org <ma...@apache.org>
Craig L Russell
clr@apache.org
Re: Secretary workbench health check?
Posted by sebb <se...@gmail.com>.
On Thu, 9 May 2019 at 11:03, sebb <se...@gmail.com> wrote:
>
> On Thu, 9 May 2019 at 10:05, sebb <se...@gmail.com> wrote:
> >
> > On Thu, 9 May 2019 at 04:48, Craig Russell <ap...@gmail.com> wrote:
> > >
> > > I am seeing three documents sent to secretary that have not appeared in the secretary workbench.
> >
> > Investigating ...
> >
> > I think I have found the messages to which you refer:
> >
> > > All times PDT (GMT -7)
> > > Tuesday 8:54 PM
> > https://mail-search.apache.org/members/private-arch/officers-secretary/201905.mbox/%3cCAKpzXcZ4OUUdg3y+dS1snfGXhP=qddAMS_efOjjKWr4sGZ0-Rg@mail.gmail.com%3e
> >
> > Message-ID: <CA...@mail.gmail.com>
> >
> > > Wednesday 12:05 AM
> > https://mail-search.apache.org/members/private-arch/officers-secretary/201905.mbox/%3c87daa111-31e1-410a-8add-a5812ad9fc90@Spark%3e
> >
> > Message-ID: <87...@Spark>
> >
> > > Wednesday 12:23 PM
> > https://mail-search.apache.org/members/private-arch/officers-secretary/201905.mbox/%3cCA+AaKM_4z+4nJ-wBiXnz4o9AvisSzn-2nvK4KUhuqaYuXfSYhA@mail.gmail.com%3e
> >
> > Message-ID: <CA...@mail.gmail.com>
> >
> > >
> > > The whimsy user interface seems to be ok. Any ideas what happened to these three ICLAs?
> >
> > About to look on Whimsy
>
> When I tried loading the 201905.yml file on my local system, all the
> messages showed up (as well as some others).
>
> The messages all appear in the JSON file, which is what drives the display:
>
> https://whimsy.apache.org/secretary/workbench/201905
>
> I don't yet know why the live site thinks there are no messages left
> to process, whereas my local copy displays several entries.
>
> The JSON is the same on my system, so it looks to be an issue with the
> Javascript.
> I will add some console logging to try and trace what is happening.
It seems that the live installation generates different Javascript
from my local version.
In particular, it handles self.merge differently; not entirely sure
what the code is trying to do.
I renamed the method and it all seems to be working now.
I think my system uses ruby2js 3.0.7 whereas whimsy-vm4 uses 3.1.0; I
assume that may be the cause.
> > > Thanks,
> > >
> > > Craig
> > >
> > > Craig L Russell
> > > clr@apache.org
> > >
Re: Secretary workbench health check?
Posted by sebb <se...@gmail.com>.
On Thu, 9 May 2019 at 10:05, sebb <se...@gmail.com> wrote:
>
> On Thu, 9 May 2019 at 04:48, Craig Russell <ap...@gmail.com> wrote:
> >
> > I am seeing three documents sent to secretary that have not appeared in the secretary workbench.
>
> Investigating ...
>
> I think I have found the messages to which you refer:
>
> > All times PDT (GMT -7)
> > Tuesday 8:54 PM
> https://mail-search.apache.org/members/private-arch/officers-secretary/201905.mbox/%3cCAKpzXcZ4OUUdg3y+dS1snfGXhP=qddAMS_efOjjKWr4sGZ0-Rg@mail.gmail.com%3e
>
> Message-ID: <CA...@mail.gmail.com>
>
> > Wednesday 12:05 AM
> https://mail-search.apache.org/members/private-arch/officers-secretary/201905.mbox/%3c87daa111-31e1-410a-8add-a5812ad9fc90@Spark%3e
>
> Message-ID: <87...@Spark>
>
> > Wednesday 12:23 PM
> https://mail-search.apache.org/members/private-arch/officers-secretary/201905.mbox/%3cCA+AaKM_4z+4nJ-wBiXnz4o9AvisSzn-2nvK4KUhuqaYuXfSYhA@mail.gmail.com%3e
>
> Message-ID: <CA...@mail.gmail.com>
>
> >
> > The whimsy user interface seems to be ok. Any ideas what happened to these three ICLAs?
>
> About to look on Whimsy
When I tried loading the 201905.yml file on my local system, all the
messages showed up (as well as some others).
The messages all appear in the JSON file, which is what drives the display:
https://whimsy.apache.org/secretary/workbench/201905
I don't yet know why the live site thinks there are no messages left
to process, whereas my local copy displays several entries.
The JSON is the same on my system, so it looks to be an issue with the
Javascript.
I will add some console logging to try and trace what is happening.
> > Thanks,
> >
> > Craig
> >
> > Craig L Russell
> > clr@apache.org
> >
Re: Secretary workbench health check?
Posted by sebb <se...@gmail.com>.
On Thu, 9 May 2019 at 04:48, Craig Russell <ap...@gmail.com> wrote:
>
> I am seeing three documents sent to secretary that have not appeared in the secretary workbench.
Investigating ...
I think I have found the messages to which you refer:
> All times PDT (GMT -7)
> Tuesday 8:54 PM
https://mail-search.apache.org/members/private-arch/officers-secretary/201905.mbox/%3cCAKpzXcZ4OUUdg3y+dS1snfGXhP=qddAMS_efOjjKWr4sGZ0-Rg@mail.gmail.com%3e
Message-ID: <CA...@mail.gmail.com>
> Wednesday 12:05 AM
https://mail-search.apache.org/members/private-arch/officers-secretary/201905.mbox/%3c87daa111-31e1-410a-8add-a5812ad9fc90@Spark%3e
Message-ID: <87...@Spark>
> Wednesday 12:23 PM
https://mail-search.apache.org/members/private-arch/officers-secretary/201905.mbox/%3cCA+AaKM_4z+4nJ-wBiXnz4o9AvisSzn-2nvK4KUhuqaYuXfSYhA@mail.gmail.com%3e
Message-ID: <CA...@mail.gmail.com>
>
> The whimsy user interface seems to be ok. Any ideas what happened to these three ICLAs?
About to look on Whimsy
> Thanks,
>
> Craig
>
> Craig L Russell
> clr@apache.org
>