You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/08/08 07:48:52 UTC
[GitHub] [solr] uschindler opened a new pull request #251: SOLR-14758: Fix NPE in QueryComponent.mergeIds when using timeAllowed and sorting
uschindler opened a new pull request #251:
URL: https://github.com/apache/solr/pull/251
See https://issues.apache.org/jira/browse/SOLR-14758 for more information and discussion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] uschindler commented on pull request #251: SOLR-14758: Fix NPE in QueryComponent.mergeIds when using timeAllowed and sorting
Posted by GitBox <gi...@apache.org>.
uschindler commented on pull request #251:
URL: https://github.com/apache/solr/pull/251#issuecomment-894769380
@intixbram I changed the check for partial results to use SolrJ API. In main branch this failed because the type of the NamedList value was different. Now it expects a boolean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] uschindler commented on pull request #251: SOLR-14758: Fix NPE in QueryComponent.mergeIds when using timeAllowed and sorting
Posted by GitBox <gi...@apache.org>.
uschindler commented on pull request #251:
URL: https://github.com/apache/solr/pull/251#issuecomment-896126000
No reviewer responded for > 2days so I merge this now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] uschindler commented on pull request #251: SOLR-14758: Fix NPE in QueryComponent.mergeIds when using timeAllowed and sorting
Posted by GitBox <gi...@apache.org>.
uschindler commented on pull request #251:
URL: https://github.com/apache/solr/pull/251#issuecomment-894760445
All tests pass for me, precommit succeeds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] uschindler commented on pull request #251: SOLR-14758: Fix NPE in QueryComponent.mergeIds when using timeAllowed and sorting
Posted by GitBox <gi...@apache.org>.
uschindler commented on pull request #251:
URL: https://github.com/apache/solr/pull/251#issuecomment-894772384
I ran the `DistributedQueryComponentCustomSortTest` test using `gradlew beast -Dtests.dups=40` and it now passed each time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] uschindler merged pull request #251: SOLR-14758: Fix NPE in QueryComponent.mergeIds when using timeAllowed and sorting
Posted by GitBox <gi...@apache.org>.
uschindler merged pull request #251:
URL: https://github.com/apache/solr/pull/251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org