You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/01/20 09:47:19 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network
ustcweizhou opened a new pull request #4600:
URL: https://github.com/apache/cloudstack/pull/4600
### Description
The fixes an issue that fails to create a vm if the name has been used by another vm.
steps to reproduce the issue
(1) create vm-1 on network-1
(2) add vm-1 to network-2
(3) remove vm-1 from network-2
(4) create another vm with same name vm-1 on network-2
expected result: operation succeed
actual result: operation failed.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4600:
URL: https://github.com/apache/cloudstack/pull/4600#issuecomment-766620783
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4600:
URL: https://github.com/apache/cloudstack/pull/4600
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4600:
URL: https://github.com/apache/cloudstack/pull/4600#issuecomment-766785992
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4600:
URL: https://github.com/apache/cloudstack/pull/4600#issuecomment-767398538
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4600:
URL: https://github.com/apache/cloudstack/pull/4600#issuecomment-764598789
nice cleanup, but shouldn't `removed` in the `listDistinctHostNames()` still be `null`? I.E. teh line 282 remain
```
DistinctHostNameSearch.and("removed", DistinctHostNameSearch.entity().getRemoved(), SearchCriteria.Op.NULL);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4600:
URL: https://github.com/apache/cloudstack/pull/4600#issuecomment-767866156
<b>Trillian test result (tid-3417)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39019 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4600-t3417-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_07_deploy_kubernetes_ha_cluster | `Failure` | 3617.87 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.08 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.06 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 73.91 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4600:
URL: https://github.com/apache/cloudstack/pull/4600#issuecomment-766620783
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4600:
URL: https://github.com/apache/cloudstack/pull/4600#issuecomment-766621269
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4600:
URL: https://github.com/apache/cloudstack/pull/4600#issuecomment-767397841
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4600:
URL: https://github.com/apache/cloudstack/pull/4600#issuecomment-764598789
nice cleanup, but shouldn't `removed` in the `listDistinctHostNames()` still be `null`? I.E. teh line 282 remain
```
DistinctHostNameSearch.and("removed", DistinctHostNameSearch.entity().getRemoved(), SearchCriteria.Op.NULL);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4600:
URL: https://github.com/apache/cloudstack/pull/4600#issuecomment-767468486
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4600:
URL: https://github.com/apache/cloudstack/pull/4600#issuecomment-766785992
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4600:
URL: https://github.com/apache/cloudstack/pull/4600#issuecomment-766817983
Packaging result: ✖centos7 ✖centos8 ✔debian. JID-2588
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4600:
URL: https://github.com/apache/cloudstack/pull/4600#issuecomment-767354931
@shwstppr thanks for tesitng.
however, I made a new commit to add back a line of code as per @DaanHoogland 's comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4600:
URL: https://github.com/apache/cloudstack/pull/4600#issuecomment-766621269
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4600:
URL: https://github.com/apache/cloudstack/pull/4600#issuecomment-767469312
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4600:
URL: https://github.com/apache/cloudstack/pull/4600#issuecomment-766786556
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4600:
URL: https://github.com/apache/cloudstack/pull/4600#issuecomment-767413184
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2592
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org