You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2016/11/21 17:27:48 UTC
[GitHub] brooklyn-server pull request #451: Adds ConfigParametersYamlTest.testPortSet...
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/451
Adds ConfigParametersYamlTest.testPortSetAsAttributeOnSoftwareProcess
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server test-config-yaml-port
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/451.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #451
----
commit 240e8f26307a344def74b6d453d9d61faac5319b
Author: Aled Sage <al...@gmail.com>
Date: 2016-11-21T17:23:25Z
Adds ConfigParametersYamlTest.testPortSetAsAttributeOnSoftwareProcess
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #451: Adds ConfigParametersYamlTest.testPortSetAsAttri...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/451
Wondered how this test is passing. Turns out that we are [creating port sensors](https://github.com/apache/brooklyn-server/blob/master/core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java#L256) in addition to the config keys from the yaml. And those get [set on the entity](https://github.com/apache/brooklyn-server/blob/master/core/src/main/java/org/apache/brooklyn/core/objs/proxy/InternalEntityFactory.java#L276) just like config keys.
The sensors aren't serialized as part of the entity type. That's fine though as the sensor sets a value for itself on start which gets serialized (along with the sensor that set it).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #451: Adds ConfigParametersYamlTest.testPortSetAsAttri...
Posted by googlielmo <gi...@git.apache.org>.
Github user googlielmo commented on the issue:
https://github.com/apache/brooklyn-server/pull/451
Tested. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #451: Adds ConfigParametersYamlTest.testPortSet...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/451
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---