You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by liming01 <gi...@git.apache.org> on 2016/09/22 07:19:17 UTC
[GitHub] incubator-hawq pull request #927: HAWQ-1068. Fixed crash at calling get_ao_c...
GitHub user liming01 opened a pull request:
https://github.com/apache/incubator-hawq/pull/927
HAWQ-1068. Fixed crash at calling get_ao_compression_ratio(null)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liming01/incubator-hawq mli/HAWQ-1068
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/927.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #927
----
commit 7a2de804918086016802351e891c6020335b46be
Author: Ming LI <ml...@apache.org>
Date: 2016-09-22T07:17:11Z
HAWQ-1068. Fixed crash at calling get_ao_compression_ratio(null)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #927: HAWQ-1068. Fixed crash at calling get_ao_c...
Posted by liming01 <gi...@git.apache.org>.
Github user liming01 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/927
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #927: HAWQ-1068. Fixed crash at calling get_ao_compress...
Posted by liming01 <gi...@git.apache.org>.
Github user liming01 commented on the issue:
https://github.com/apache/incubator-hawq/pull/927
@karthijrk, I just fixed get_ao_compression_ratio_name() and get_ao_compression_ratio_oid(), if other functions need to be fixed, please open defect for them. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #927: HAWQ-1068. Fixed crash at calling get_ao_compress...
Posted by karthijrk <gi...@git.apache.org>.
Github user karthijrk commented on the issue:
https://github.com/apache/incubator-hawq/pull/927
Quick comment : We were trying to see if we can port this fix to gpdb. In general, by design Postgres / GPDB doesn't check for null in low-level API. Instead, when the arguments get evaluated, it sets the `isNull` flag appropriately. Shouldn't the fix be to see why that flag was not set to true when the argument was evaluated ?
For.eg. if we do select texteq(null, 'dfd') it doesn't crash because first argument's `isNull` set to true and hence it didn't execute `texteq`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---