You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/02/04 17:18:37 UTC
[GitHub] [tvm] sunggg opened a new pull request #10169: [MetaSchedule] Add target field to MetaScheduleContext
sunggg opened a new pull request #10169:
URL: https://github.com/apache/tvm/pull/10169
Since a tuning task can be target-dependent, this PR adds target field to `MetaScheduleContext` and `ExtractedTask` to maintain target information.
cc: @junrushao1994 @zxybazh
I've also noticed that current database interface commits and query workload in target-agnostic fashion.
https://github.com/apache/tvm/blob/main/tests/python/unittest/test_meta_schedule_integration.py#L169-L173
I think `workload` = `mod` + `target` in the same context with the change in this PR, but I would be happy to receive other inputs before I make the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 merged pull request #10169: [MetaSchedule] Add target field to MetaScheduleContext
Posted by GitBox <gi...@apache.org>.
junrushao1994 merged pull request #10169:
URL: https://github.com/apache/tvm/pull/10169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jroesch commented on pull request #10169: [MetaSchedule] Add target field to MetaScheduleContext
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #10169:
URL: https://github.com/apache/tvm/pull/10169#issuecomment-1030426651
How does this interact with heterogeneous tuning? do we get one context per target? cc @mbs-octoml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #10169: [MetaSchedule] Add target field to MetaScheduleContext
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #10169:
URL: https://github.com/apache/tvm/pull/10169#issuecomment-1030275118
@sunggg Thanks for the PR! It makes perfect sense for me :-) In terms of the database interface, we intentionally dedicate an IRModule in the workload registry, while target is saved per TuningRecord, because the target could potentially differ for the same IRModule
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sunggg commented on pull request #10169: [MetaSchedule] Add target field to MetaScheduleContext
Posted by GitBox <gi...@apache.org>.
sunggg commented on pull request #10169:
URL: https://github.com/apache/tvm/pull/10169#issuecomment-1030280509
@junrushao1994 Thank you for the input! Yeah, I've noticed that but it seems like we don't pass target in the query for `ApplyHistoryBest`? How do we prevent `ApplyHistoryBest` fetching wrong configuration for different target?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zxybazh commented on pull request #10169: [MetaSchedule] Add target field to MetaScheduleContext
Posted by GitBox <gi...@apache.org>.
zxybazh commented on pull request #10169:
URL: https://github.com/apache/tvm/pull/10169#issuecomment-1030467718
> @junrushao1994 Thank you for the input! Yeah, I've noticed that but it seems like we don't pass target in the query for `ApplyHistoryBest`? How do we prevent `ApplyHistoryBest` fetching wrong configuration for different target?
I think it's a good point. The workload's runing result only make sense for certain target. In that case, we should only fetch the tuning record given the target.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org