You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by dhatchayani <gi...@git.apache.org> on 2018/01/23 10:01:44 UTC

[GitHub] carbondata pull request #1847: [CARBONDATA-2064] Add compaction listener

GitHub user dhatchayani opened a pull request:

    https://github.com/apache/carbondata/pull/1847

    [CARBONDATA-2064] Add compaction listener

    Added compaction listeners
    
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [x] Testing done
            Manual Testing
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhatchayani/incubator-carbondata compactionListeners

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1847.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1847
    
----
commit 4b679aae54ee8fcd87bd666d0a8641ad1b50a0e3
Author: dhatchayani <dh...@...>
Date:   2018-01-23T09:56:26Z

    [CARBONDATA-2064] Add compaction listener

----


---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3241/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3388/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1827/



---

[GitHub] carbondata issue #1847: [CARBONDATA-2064] Add compaction listener

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    LGTM


---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1839/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3212/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3046/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3225/



---

[GitHub] carbondata issue #1847: [CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2183/



---

[GitHub] carbondata pull request #1847: [CARBONDATA-2064] Add compaction listener

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1847


---

[GitHub] carbondata issue #1847: [CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3421/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    retest this please


---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2146/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3059/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3307/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3269/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    retest sdv please


---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1822/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2070/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3053/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1991/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2151/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3056/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3325/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1824/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3045/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3044/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3209/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Retest this please


---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3198/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2110/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2091/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3346/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    retest this please


---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3383/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1978/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3252/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3184/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3060/



---

[GitHub] carbondata pull request #1847: [WIP][CARBONDATA-2064] Add compaction listene...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1847#discussion_r164939374
  
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datacompaction/CarbonIndexFileMergeTestCase.scala ---
    @@ -1,199 +0,0 @@
    -/*
    - * Licensed to the Apache Software Foundation (ASF) under one or more
    - * contributor license agreements.  See the NOTICE file distributed with
    - * this work for additional information regarding copyright ownership.
    - * The ASF licenses this file to You under the Apache License, Version 2.0
    - * (the "License"); you may not use this file except in compliance with
    - * the License.  You may obtain a copy of the License at
    - *
    - *    http://www.apache.org/licenses/LICENSE-2.0
    - *
    - * Unless required by applicable law or agreed to in writing, software
    - * distributed under the License is distributed on an "AS IS" BASIS,
    - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    - * See the License for the specific language governing permissions and
    - * limitations under the License.
    - */
    -
    -package org.apache.carbondata.spark.testsuite.datacompaction
    -
    -import org.apache.spark.sql.test.util.QueryTest
    -import org.scalatest.{BeforeAndAfterAll, BeforeAndAfterEach}
    -
    -import org.apache.carbondata.core.constants.CarbonCommonConstants
    -import org.apache.carbondata.core.datastore.filesystem.{CarbonFile, CarbonFileFilter}
    -import org.apache.carbondata.core.datastore.impl.FileFactory
    -import org.apache.carbondata.core.metadata.CarbonMetadata
    -import org.apache.carbondata.core.util.CarbonProperties
    -import org.apache.carbondata.core.util.path.CarbonTablePath
    -
    -class CarbonIndexFileMergeTestCase
    --- End diff --
    
    Don't remove the test case, use direct API to merge instead of using DDL


---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3070/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1975/



---

[GitHub] carbondata issue #1847: [WIP][CARBONDATA-2064] Add compaction listener

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1847
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3172/



---