You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Jan Høydahl (Jira)" <ji...@apache.org> on 2024/01/12 14:21:00 UTC

[jira] [Commented] (SOLR-17115) OTEL: Option to skip certain spans from being exported

    [ https://issues.apache.org/jira/browse/SOLR-17115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806064#comment-17806064 ] 

Jan Høydahl commented on SOLR-17115:
------------------------------------

The strategy will be to wrap either Sampler or SpanExporter with a custom plugin that will drop skipped spans.

Pros of wrapping the Sampler is that spans will be dropped before sent to exporter, but con is we don't have access to SpanData object with span name (e.g. "get:/admin/info/system"), only the "http.url" object, which is not that nice to work with. So if we go for the Sampler approach, the var will likely look like {{{}SOLR_TRACE_SKIP_PATH_REGEX="admin/info/(health|system)"{}}}, checking the path part of the URL.

If wrapping SpanExporter, we get access to SpanData and can work on the span names. But Then we will get a list of spans that we have to traverse and emit a filtered list to the wrapped exporter.

Feedback on other possible approaches is welcome.

> OTEL: Option to skip certain spans from being exported
> ------------------------------------------------------
>
>                 Key: SOLR-17115
>                 URL: https://issues.apache.org/jira/browse/SOLR-17115
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: tracing
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>            Priority: Major
>
> Certain trace spans such as {{get:/admin/info/system}} and {{get:/admin/info/health}} are very frequent and not always helpful to have in Jaeger trace store. There is no native way to filter spans in OTEL Java SDK. This issue is to add a new ENV that will allow users to filter by span name. E.g.
> {code}
> SOLR_TRACE_SKIP_SPANS="get:/admin/info/health,get:/admin/info/system"
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org